From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veli-Pekka Peltola Date: Fri, 04 Nov 2011 15:13:14 +0200 Subject: [U-Boot] [PATCH 09/17 RESEND V5] iMX28: Add GPMI NAND driver In-Reply-To: <1319237066-14954-10-git-send-email-marek.vasut@gmail.com> References: <1315800409-19876-1-git-send-email-marek.vasut@gmail.com> <1319237066-14954-1-git-send-email-marek.vasut@gmail.com> <1319237066-14954-10-git-send-email-marek.vasut@gmail.com> Message-ID: <4EB3E4EA.9080509@bluegiga.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 10/22/2011 01:44 AM, Marek Vasut wrote: > diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c > new file mode 100644 > index 0000000..ce2a326 > --- /dev/null > +++ b/drivers/mtd/nand/mxs_nand.c > + nand->options |= NAND_NO_SUBPAGE_WRITE; I think we should change this a little bit. Unluckily I don't know what is the best way to fix it. As far as I have understood, the NAND_NO_SUBPAGE_WRITE is a chip option, not for a driver. At nand_base.c is chip->options &= ~NAND_CHIPOPTIONS_MSK; chip->options |= type->options & NAND_CHIPOPTIONS_MSK; so the bit is masked out anyway and subpages are enabled. After that UBI tries to read VID header at 512 by default. I had to use "ubi part root 2048" to override it. Besides of that driver seems to work fine. -- Veli-Pekka Peltola Bluegiga Technologies