From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sat, 05 Nov 2011 15:09:51 +0100
Subject: [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU
In-Reply-To: <20111105132610.C3457189300E@gemini.denx.de>
References: <1320045986-3282-1-git-send-email-weisserm@arcor.de>
	<4EB514C7.9000503@aribaud.net>
	<20111105132610.C3457189300E@gemini.denx.de>
Message-ID: <4EB543AF.7010006@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 05/11/2011 14:26, Wolfgang Denk a ?crit :
> Dear Albert ARIBAUD,
>
> In message<4EB514C7.9000503@aribaud.net>  you wrote:
>>
>>> +#ifndef MACH_TYPE_JADECPU
>>> +#define MACH_TYPE_JADECPU	2636
>>> +#endif
>>
>> NAK -- remove ifndef/endif around definition. This way, if/when mach
>> type reappears in official mach-type.h, we will get a warning about your
>> mach-type being defined twice.
>
> Note that you will only get a warning if a _different_ value get's
> defined (``warning: "VAR" redefined'').  If both values are the same,
> no warning will be raised.

Hmm, correct. In order to catch the mach-type creeping back in 
mach-types.h, we'd need to define something like

	#define MACH_TYPE_JADECPU	(2636)

I'll post an ARM-global patch for this, but as it will obviously not be 
a bugfix, it'll wait until next merge window.

> Best regards,
>
> Wolfgang Denk

Amicalement,
-- 
Albert.