From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 05 Nov 2011 16:04:35 +0100 Subject: [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU In-Reply-To: <20111105145605.642851893013@gemini.denx.de> References: <1320045986-3282-1-git-send-email-weisserm@arcor.de> <4EB514C7.9000503@aribaud.net> <20111105132610.C3457189300E@gemini.denx.de> <4EB543AF.7010006@aribaud.net> <20111105145605.642851893013@gemini.denx.de> Message-ID: <4EB55083.4040304@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 05/11/2011 15:56, Wolfgang Denk a ?crit : > Dear Albert ARIBAUD, > > In message<4EB543AF.7010006@aribaud.net> you wrote: >> >>> Note that you will only get a warning if a _different_ value get's >>> defined (``warning: "VAR" redefined''). If both values are the same, >>> no warning will be raised. >> >> Hmm, correct. In order to catch the mach-type creeping back in >> mach-types.h, we'd need to define something like >> >> #define MACH_TYPE_JADECPU (2636) >> >> I'll post an ARM-global patch for this, but as it will obviously not be >> a bugfix, it'll wait until next merge window. > > Please save the effort. Waht would it be good for? As long as the > values are the same, it's OK anyway. And if they should be different, > we get a bunch of warnings. Just wanted to make sure we know when the temporary MACH_TYPE addition in the config header becomes obsolete. But then, I can also run a grep on include/configs/*.h whenever mach-types.h is updated. > Best regards, > > Wolfgang Denk Amicalement, -- Albert.