From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sun, 06 Nov 2011 15:54:56 +0100 Subject: [U-Boot] [PATCH] NAND: Let NAND_NO_SUBPAGE_WRITE through In-Reply-To: <201111061343.45155.marek.vasut@gmail.com> References: <1320459844-18243-1-git-send-email-marek.vasut@gmail.com> <4EB64CE2.4090702@denx.de> <201111061343.45155.marek.vasut@gmail.com> Message-ID: <4EB69FC0.2060500@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/06/2011 01:43 PM, Marek Vasut wrote: > > Yes sure, but the controller driver sets it as a chip option as there's no > "controller" option field and I don't want to introduce new definition consuming > one bit in the top half of chip option. Let's see how evolve the discussion - allowing to mix chip and controller options was > > No, the controller must set NAND_NO_SUBPAGE_WRITE as a chip option in its driver > to force it so it should work for both cases. As far as I remember (not very well, I admit..), the only way for the driver to set them was in the board_nand_init(), but these options are overwritten when the flash is detected, making NAND_NO_SUBPAGE_WRITE worthless. Am I wrong ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================