From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Date: Mon, 07 Nov 2011 15:59:53 +0100 Subject: [U-Boot] [PATCH v7 4/4] usb: add USB support for Efika In-Reply-To: <4EB16CC5.9080408@denx.de> References: <1317314665-31835-1-git-send-email-fermata7@gmail.com> <1320175491-15124-1-git-send-email-fermata7@gmail.com> <4EB1135B.1030303@compulab.co.il> <4EB16CC5.9080408@denx.de> Message-ID: <4EB7F269.5030407@grandegger.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/02/2011 05:16 PM, Stefano Babic wrote: > On 11/02/2011 05:03 PM, Jana Rapava wrote: >> >> Ok, so non-board-specific parts should go into ./arch/arm/cpu/armv7/mx5/ >> and board-specific callbacks should stay here? Do I understand you well? > > Yes, I think so > >> >>> >>> I don't want to block on that issue, so if it simplifies you a >>> further ULPI patches submission - I don't care if you leave it here >>> and in the next patch set move to a common location. >>> >>> >> Thanks. > > Anyway, as we agree, it is really better to do now the right thing as to > postpone. I'm want to provide USB support for mx53loco and maybe mx51evk, similar to what Jana is doing. Following the "drivers/usb/host/ehci mxc.c" example, I tried to do it the generic way by implementing "drivers/usb/host/ehci-mx5.c". Not sure if it's the better approach as a board specific initialization/reset might be required for some boards. Therefore board specific callbacks would make sense. I have attached my patch below for review and comments. Thanks, Wolfgang,