public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Continuation line alignment
Date: Tue, 08 Nov 2011 11:20:47 +0100	[thread overview]
Message-ID: <4EB9027F.808@keymile.com> (raw)
In-Reply-To: <4EB8708D.1050405@freescale.com>

On 11/08/2011 12:58 AM, Scott Wood wrote:
 > I like aligning based on which level of nested parens the line break is
 > in (and removing unnecessary parens when precedence is obvious, to make
 > it easier to track the relevant ones):
 >
 > 	if ((day_of_week() % 2 == 0&&
 > 	(temperature()<  14.4 || temperature()>  15.3)) ||
 > 	    (sky_color() == E_BLUE&&  sim_credit() % 100 != 27) ||
 > 	    uptime()<  3600) {
 > 		work = 1;
 > 	} else if ((received_calls()>  1&&
 > 		zenith_angle() == 0) ||
 > 		   call_is_important()) {
 > 		work = 0;
 > 	} else {
 > 		udelay(rand());
 > 		work = ((rand() % 2) == 1);
 > 	}

I like that too.

Anyway... Are there are any guidelines for indenting comments on the 
right side of the code? Like:

	if ((day_of_week() % 2 == 0 &&		/* even days are OK */
	     (temperature() < 14.4 || temperature() > 15.3)) ||
						/*
						 * but only outside of a
						 * certain temp. range
						 */
	    (sky_color() == E_BLUE && sim_credit() % 100 != 27) ||
						/*
						 * or, it's a nice a day
						 * but balance does not
						 * have 27 cents as
						 * decimal part
						 */
	    uptime() < 3600) {			/* work 4 the 1st hr! */
		work = 1;
	} else if ((received_calls() > 1 &&
		    zenith_angle() == 0) ||
		   call_is_important()) {
		work = 0;
	} else {
		udelay(rand());
		work = ((rand() % 2) == 1);
	}

... becuase git-gui will interpret all tabs which are on the right of 
some non-whitespace text in a very weird way.
Is using tabs on the right of text forbidden/not recommended for some 
reason?

Thanks!
Gerlando Falauto

  reply	other threads:[~2011-11-08 10:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 16:37 [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars Gerlando Falauto
2011-10-26 16:37 ` [U-Boot] [PATCH v0 1/4] Groundwork for generalization of env interface Gerlando Falauto
2011-11-05 16:09   ` Wolfgang Denk
2011-11-07 21:06     ` Gerlando Falauto
2011-11-07 22:05       ` Wolfgang Denk
2011-11-07 23:02         ` [U-Boot] Continuation line alignment Scott Wood
2011-11-07 23:32           ` Gerlando Falauto
2011-11-07 23:44             ` Scott Wood
2011-11-07 23:58             ` Scott Wood
2011-11-08 10:20               ` Gerlando Falauto [this message]
2011-11-07 23:05         ` [U-Boot] [PATCH v0 1/4] Groundwork for generalization of env interface Gerlando Falauto
2011-11-07 23:30           ` Wolfgang Denk
2011-11-05 16:34   ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 2/4] env: check and apply changes on delete/destroy Gerlando Falauto
2011-11-05 16:13   ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 3/4] env: implement selective "env default" Gerlando Falauto
2011-11-05 16:40   ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 4/4] env: implement "env import -n var[, var...]" Gerlando Falauto
2011-11-06 19:52 ` [U-Boot] [PATCH] env: fix "env ask" command Wolfgang Denk
2011-11-06 19:55   ` [U-Boot] [PATCH 1/2] Add SLRE - Super Light Regular Expression library Wolfgang Denk
2011-11-06 19:55     ` [U-Boot] [PATCH 2/2] env: add regex support for environment variables Wolfgang Denk
2011-11-07 11:07       ` Detlev Zundel
2013-03-22 21:44     ` [U-Boot] [PATCH 0/9] Add Regular Expressions Support Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 1/9] hashtable: preparations to use hexport_r() for "env grep" Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 2/9] "env grep" - reimplement command using hexport_r() Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 3/9] "env grep" - add options to grep in name, value, or both Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 4/9] Add SLRE - Super Light Regular Expression library Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 5/9] "env grep" - add support for regular expression matches Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 6/9] setexpr: simplify code, improve help message Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 7/9] setexpr: add regex substring matching and substitution Wolfgang Denk
2013-03-22 22:36         ` Marek Vasut
2013-03-24  9:38           ` Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 8/9] m28evk: enable "env grep" and regexp support Wolfgang Denk
2013-03-22 21:44       ` [U-Boot] [PATCH 9/9] amcc-common.h: enable support for "env grep", "setexpr", and regex Wolfgang Denk
2013-03-22 21:50       ` [U-Boot] [PATCH 0/9] Add Regular Expressions Support Wolfgang Denk
2013-03-23 12:18       ` Otavio Salvador
2013-03-24  9:41         ` Wolfgang Denk
2013-02-20 14:53   ` [U-Boot] [PATCH] env: fix "env ask" command Wolfgang Denk
2011-11-06 19:57 ` [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars Wolfgang Denk
2011-11-06 22:15 ` Wolfgang Denk
2011-11-08  9:33   ` Gerlando Falauto
2011-11-08 11:46     ` Wolfgang Denk
2011-11-08 12:04       ` Gerlando Falauto
2011-11-08 12:47         ` Wolfgang Denk
2011-11-08 13:33           ` Holger Brunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB9027F.808@keymile.com \
    --to=gerlando.falauto@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox