[U-Boot] [PATCH] ulpi: add generic ULPI support header file

Igor Grinberg
2011-11-02T14:19:51Z

On 11/02/11 15:38, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> In message <4EB110D3.5020400@compulab.co.il> you wrote:
>>
>> In the structure above, you have a mixture of tab and spaces
>> after the type before the name.
>> You can use either tabs or spaces (I prefer spaces), but not both.
>
> http://www.denx.de/wiki/U-Boot/CodingStyle states clearly:
>
> Use TAB characters for indentation and vertical alignment, not
> spaces.

Of course not spaces, Wolfgang, you've misunderstood what I said.
It is one space for one line, see the example below.

That's how it looks currently:
struct something {
type var1;
type var2;
type var3;
type var4;
};

What I mean is either of two:

struct something {
type var1;
type var2;
type var3;
type var3;
};

or

struct something {
type var1;
type var2;
type var3;
type var3;
};

The second is motivated by absence of an alignment issue,
because the type is always the same (u8).
Now, if the type is different among fields, then of course tab(s)
should be used for alignment!

Hope now we are talking the same thing.

--
Regards,
Igor.