From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars
Date: Tue, 08 Nov 2011 14:33:11 +0100 [thread overview]
Message-ID: <4EB92F97.2060801@keymile.com> (raw)
In-Reply-To: <20111108124720.D019A13BE08A@gemini.denx.de>
Hi,
On 11/08/2011 01:47 PM, Wolfgang Denk wrote:
>>>
>>> env import [-t | -b | -c] [-s size] addr [var ...]
>>>
>>> This also greatly simplifies the implementation.
>>
>> Totally agree. Question is: won't that break all the existing scripts???
>
> Yes. It _is_ an incompatible change of the API. I hate it, but
> mostly because I didn't chose such a format right from the beginning.
>
> My hope is that probably not too many people use these features in
> scripts - at least so far it's only omap3_beagle and omap3_mvblx that
> use "env import -t $loadaddr $filesize". It is IMO better to change
> this now, instead of waiting until we have more users and the problem
> hits us in another place, hard.
>
we use it too in keymile-common.h and in the scripts we load with this command
e.g. board/keymile/scripts/develop-ppc_82xx.txt
The resulting incompatibility is indeed not very nice. I don't see big issues
for the command line and keymile-common.h where we can live with different API
for different u-boot versions. But the usage in the scripts directory is more
complicated, because then we have to make sure that uboot version x loads
scripts x and u-boot version y loads scripts y. Ok we could prepare a second
scripts directory e.g. "scripts_v2" or similar in addition to the current
scripts directory in tftpboot, but this is not very nice.
Best regards
Holger
prev parent reply other threads:[~2011-11-08 13:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 16:37 [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars Gerlando Falauto
2011-10-26 16:37 ` [U-Boot] [PATCH v0 1/4] Groundwork for generalization of env interface Gerlando Falauto
2011-11-05 16:09 ` Wolfgang Denk
2011-11-07 21:06 ` Gerlando Falauto
2011-11-07 22:05 ` Wolfgang Denk
2011-11-07 23:02 ` [U-Boot] Continuation line alignment Scott Wood
2011-11-07 23:32 ` Gerlando Falauto
2011-11-07 23:44 ` Scott Wood
2011-11-07 23:58 ` Scott Wood
2011-11-08 10:20 ` Gerlando Falauto
2011-11-07 23:05 ` [U-Boot] [PATCH v0 1/4] Groundwork for generalization of env interface Gerlando Falauto
2011-11-07 23:30 ` Wolfgang Denk
2011-11-05 16:34 ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 2/4] env: check and apply changes on delete/destroy Gerlando Falauto
2011-11-05 16:13 ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 3/4] env: implement selective "env default" Gerlando Falauto
2011-11-05 16:40 ` Wolfgang Denk
2011-10-26 16:37 ` [U-Boot] [PATCH v0 4/4] env: implement "env import -n var[, var...]" Gerlando Falauto
2011-11-06 19:52 ` [U-Boot] [PATCH] env: fix "env ask" command Wolfgang Denk
2011-11-06 19:55 ` [U-Boot] [PATCH 1/2] Add SLRE - Super Light Regular Expression library Wolfgang Denk
2011-11-06 19:55 ` [U-Boot] [PATCH 2/2] env: add regex support for environment variables Wolfgang Denk
2011-11-07 11:07 ` Detlev Zundel
2013-03-22 21:44 ` [U-Boot] [PATCH 0/9] Add Regular Expressions Support Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 1/9] hashtable: preparations to use hexport_r() for "env grep" Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 2/9] "env grep" - reimplement command using hexport_r() Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 3/9] "env grep" - add options to grep in name, value, or both Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 4/9] Add SLRE - Super Light Regular Expression library Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 5/9] "env grep" - add support for regular expression matches Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 6/9] setexpr: simplify code, improve help message Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 7/9] setexpr: add regex substring matching and substitution Wolfgang Denk
2013-03-22 22:36 ` Marek Vasut
2013-03-24 9:38 ` Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 8/9] m28evk: enable "env grep" and regexp support Wolfgang Denk
2013-03-22 21:44 ` [U-Boot] [PATCH 9/9] amcc-common.h: enable support for "env grep", "setexpr", and regex Wolfgang Denk
2013-03-22 21:50 ` [U-Boot] [PATCH 0/9] Add Regular Expressions Support Wolfgang Denk
2013-03-23 12:18 ` Otavio Salvador
2013-03-24 9:41 ` Wolfgang Denk
2013-02-20 14:53 ` [U-Boot] [PATCH] env: fix "env ask" command Wolfgang Denk
2011-11-06 19:57 ` [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars Wolfgang Denk
2011-11-06 22:15 ` Wolfgang Denk
2011-11-08 9:33 ` Gerlando Falauto
2011-11-08 11:46 ` Wolfgang Denk
2011-11-08 12:04 ` Gerlando Falauto
2011-11-08 12:47 ` Wolfgang Denk
2011-11-08 13:33 ` Holger Brunck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB92F97.2060801@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox