* [U-Boot] [PATCH] fsl_i2c: Fix compile warning
@ 2011-11-08 13:39 Kumar Gala
2011-11-08 16:59 ` Marek Vasut
2011-11-09 5:29 ` Heiko Schocher
0 siblings, 2 replies; 4+ messages in thread
From: Kumar Gala @ 2011-11-08 13:39 UTC (permalink / raw)
To: u-boot
fsl_i2c.c: In function 'i2c_init':
fsl_i2c.c:245:7: warning: assignment discards qualifiers from pointer target type
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/i2c/fsl_i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
index 258be0a..5b017a9 100644
--- a/drivers/i2c/fsl_i2c.c
+++ b/drivers/i2c/fsl_i2c.c
@@ -225,7 +225,7 @@ unsigned int get_i2c_clock(int bus)
void
i2c_init(int speed, int slaveadd)
{
- struct fsl_i2c *dev;
+ const struct fsl_i2c *dev;
unsigned int temp;
int bus_num, i;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] fsl_i2c: Fix compile warning
2011-11-08 13:39 [U-Boot] [PATCH] fsl_i2c: Fix compile warning Kumar Gala
@ 2011-11-08 16:59 ` Marek Vasut
2011-11-08 17:14 ` Kumar Gala
2011-11-09 5:29 ` Heiko Schocher
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2011-11-08 16:59 UTC (permalink / raw)
To: u-boot
> fsl_i2c.c: In function 'i2c_init':
> fsl_i2c.c:245:7: warning: assignment discards qualifiers from pointer
> target type
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/i2c/fsl_i2c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
> index 258be0a..5b017a9 100644
> --- a/drivers/i2c/fsl_i2c.c
> +++ b/drivers/i2c/fsl_i2c.c
> @@ -225,7 +225,7 @@ unsigned int get_i2c_clock(int bus)
> void
> i2c_init(int speed, int slaveadd)
> {
> - struct fsl_i2c *dev;
> + const struct fsl_i2c *dev;
> unsigned int temp;
> int bus_num, i;
Kumar, just a offtopic question. Is this driver actually handling the same IP
block as mxc_i2c driver (aka. is it the same IP block as used in iMX ARM CPUs)?
M
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] fsl_i2c: Fix compile warning
2011-11-08 16:59 ` Marek Vasut
@ 2011-11-08 17:14 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2011-11-08 17:14 UTC (permalink / raw)
To: u-boot
On Nov 8, 2011, at 10:59 AM, Marek Vasut wrote:
>> fsl_i2c.c: In function 'i2c_init':
>> fsl_i2c.c:245:7: warning: assignment discards qualifiers from pointer
>> target type
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> drivers/i2c/fsl_i2c.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
>> index 258be0a..5b017a9 100644
>> --- a/drivers/i2c/fsl_i2c.c
>> +++ b/drivers/i2c/fsl_i2c.c
>> @@ -225,7 +225,7 @@ unsigned int get_i2c_clock(int bus)
>> void
>> i2c_init(int speed, int slaveadd)
>> {
>> - struct fsl_i2c *dev;
>> + const struct fsl_i2c *dev;
>> unsigned int temp;
>> int bus_num, i;
>
> Kumar, just a offtopic question. Is this driver actually handling the same IP
> block as mxc_i2c driver (aka. is it the same IP block as used in iMX ARM CPUs)?
>
> M
I believe it is but not 100% sure on that.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] fsl_i2c: Fix compile warning
2011-11-08 13:39 [U-Boot] [PATCH] fsl_i2c: Fix compile warning Kumar Gala
2011-11-08 16:59 ` Marek Vasut
@ 2011-11-09 5:29 ` Heiko Schocher
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2011-11-09 5:29 UTC (permalink / raw)
To: u-boot
Hello Kumar,
Kumar Gala wrote:
> fsl_i2c.c: In function 'i2c_init':
> fsl_i2c.c:245:7: warning: assignment discards qualifiers from pointer target type
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/i2c/fsl_i2c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks! Applied to u-boot-i2c.git
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-09 5:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08 13:39 [U-Boot] [PATCH] fsl_i2c: Fix compile warning Kumar Gala
2011-11-08 16:59 ` Marek Vasut
2011-11-08 17:14 ` Kumar Gala
2011-11-09 5:29 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox