From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 09 Nov 2011 06:37:45 +0100 Subject: [U-Boot] [RFC PATCH] arm, davinci: Remove board specific code from da850_lowlevel.c In-Reply-To: <1320745155-9256-1-git-send-email-christian.riesch@omicron.at> References: <1320745155-9256-1-git-send-email-christian.riesch@omicron.at> Message-ID: <4EBA11A9.6060905@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Christian, Christian Riesch wrote: > Signed-off-by: Christian Riesch > --- > > Hello Heiko, > > On my board I cannot use your code in arch_cpu_init() in da850_lowlevel.c > since I have different versions of my board with different input > clock frequencies. Here u-boot should first determine the board > revision number and then configure the SoC accordingly. Therefore I would > like to move all board-specific parts (and PLL and memory configuration is > board-specific since it depends on the memory chips and oscillators > deployed on the board) to board_early_init_f which is called right after > arch_cpu_init() and keep only a few initializiation steps in arch_cpu_init(). Ok, if you have other needs on your board we must change something. But I want to prevent, that all the code you remove in your patch is moved to board code, so all boards must (copy?) it. Instead you should move it to a weak function, which you can replace for your specific needs. (I thought the code was common enough ...) What do you think? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany