From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] OMAP3: Add SPL support to Beagleboard
Date: Wed, 09 Nov 2011 13:07:56 +0200 [thread overview]
Message-ID: <4EBA5F0C.7050805@compulab.co.il> (raw)
In-Reply-To: <4EB94AA2.8000608@ti.com>
On 11/08/11 17:28, Tom Rini wrote:
> On 11/08/2011 12:57 AM, Igor Grinberg wrote:
>> On 11/07/11 22:05, Tom Rini wrote:
>>> This introduces 200MHz Micron parts timing information based on x-loader
>>> to <asm/arch-omap3/mem.h>. The memory init logic is also based on what
>>> x-loader does in these cases. Note that while previously u-boot would
>>> be flashed in with SW ECC in this case it now must be flashed with HW
>>> ECC.
> [snip]
>>> +#ifdef CONFIG_SPL_BUILD
>>> +/*
>>> + * Routine: board_early_sdrc_init
>>
>> s/board_early_sdrc_init/get_board_mem_timings/
>>
>>> + * Description: If we use SPL then there is no x-loader nor config header
>>> + * so we have to setup the DDR timings outself on both banks.
>>
>> s/outself/ourself/
>
> Thanks.
>
> [snip]
>>> + case REVISION_C4:
>>> + if ((pop_mfr == NAND_MFR_STMICRO) && (pop_id == 0xba)) {
>>
>> No need for extra parenthesis.
>
> I'll double check all these cases, thanks.
>
>>> + *mcfg = 0x04590099;
>>> + *ctrla = NUMONYX_V_ACTIMA_165;
>>> + *ctrlb = NUMONYX_V_ACTIMB_165;
>>> + *rfr_ctrl = SDP_3430_SDRC_RFR_CTRL_165MHz;
>>
>> This will look much better if it will be aligned.
>
> It's not in CodingStyle tho ;)
Right, you don't have to, but it will look better...
>
> [snip]
>>> -# For use with external or internal boots.
>>> -CONFIG_SYS_TEXT_BASE = 0x80008000
>>
>> Removing needless crap is a very good thing, but does not
>> belong to this patch, is it?
>
> I thought I said in this commit message, but I know I did for am3517
> evm/crane, we change CONFIG_SYS_TEXT_BASE which is why we remove this
> file here. It could be done as a two-step if it's a hard objection tho.
Yeah, I've sent this email before I saw the AM3517 changes.
Ok.
--
Regards,
Igor.
next prev parent reply other threads:[~2011-11-09 11:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:05 [U-Boot] [PATCH 0/12]: Add more framework to OMAP3 SPL, port more boards Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 01/12] OMAP3: Update SDRC dram_init to always call make_cs1_contiguous() Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 02/12] OMAP3: Add a helper function to set timings in SDRC Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 03/12] OMAP3: Change mem_ok to clear again after reading back Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 04/12] OMAP3: Remove get_mem_type prototype Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 05/12] OMAP3: Add optimal SDRC autorefresh control values Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 06/12] OMAP3: Suffix all Micron memory timing parts with their speed Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 07/12] OMAP3 SPL: Rework memory initalization and devkit8000 support Tom Rini
2011-11-08 7:06 ` Igor Grinberg
2011-11-08 15:09 ` Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 08/12] OMAP3 SPL: Add identify_pop_memory function Tom Rini
2011-11-08 7:45 ` Igor Grinberg
2011-11-08 15:21 ` Tom Rini
2011-11-09 11:04 ` Igor Grinberg
2011-11-09 16:41 ` Tom Rini
2011-11-07 20:05 ` [U-Boot] [PATCH 09/12] OMAP3: Add SPL support to Beagleboard Tom Rini
2011-11-08 7:57 ` Igor Grinberg
2011-11-08 15:28 ` Tom Rini
2011-11-09 11:07 ` Igor Grinberg [this message]
2011-11-07 22:03 ` [U-Boot] [PATCH 10/12] OMAP3: Add SPL support to omap3_evm Tom Rini
2011-11-08 8:02 ` Igor Grinberg
2011-11-08 15:29 ` Tom Rini
2011-11-08 16:06 ` Tom Rini
2011-11-07 22:03 ` [U-Boot] [PATCH 11/12] AM3517: Add SPL support Tom Rini
2011-11-07 22:03 ` [U-Boot] [PATCH 12/12] AM3517 CraneBoard: " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA5F0C.7050805@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox