From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/13] board/evb64260/i2c.c: Coding Style cleanup
Date: Thu, 10 Nov 2011 07:32:20 +0100 [thread overview]
Message-ID: <4EBB6FF4.5060105@denx.de> (raw)
In-Reply-To: <1320866946-28235-2-git-send-email-wd@denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> Make checkpatch-clean
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Eran Man <eran@nbase.co.il>
> ---
> board/evb64260/i2c.c | 48 ++++++++++++++++++++++--------------------------
> 1 files changed, 22 insertions(+), 26 deletions(-)
>
> diff --git a/board/evb64260/i2c.c b/board/evb64260/i2c.c
> index 88d0dac..573f31f 100644
> --- a/board/evb64260/i2c.c
> +++ b/board/evb64260/i2c.c
> @@ -20,25 +20,22 @@ static void
> i2c_init(int speed, int slaveaddr)
> {
> unsigned int n, m, freq, margin, power;
> - unsigned int actualFreq, actualN=0, actualM=0;
> + unsigned int actualFreq, actualN = 0, actualM = 0;
Hmm.. we don't use Upper and Lower case mixed for variable names.
This should be cleanuped too.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-11-10 6:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 19:28 [U-Boot] [PATCH 01/13] drivers/block/sym53c8xx.c: Fix GCC 4.6 build warning Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 02/13] board/evb64260/i2c.c: Coding Style cleanup Wolfgang Denk
2011-11-10 6:32 ` Heiko Schocher [this message]
2011-11-16 20:03 ` Wolfgang Denk
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 03/13] board/evb64260/i2c.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-10 6:33 ` Heiko Schocher
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 04/13] board/evb64260/evb64260.c: Fix GC 4.6 build warning Wolfgang Denk
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 05/13] board/evb64260/eth.c: Fix GCC " Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 06/13] board/evb64260/sdram_init.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 07/13] board/evb64260/zuma_pbb_mbox.c: CodingStyle cleanup Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 08/13] board/evb64260/zuma_pbb_mbox.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 09/13] common/cmd_fdc.c: " Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 10/13] common/cmd_universe.c: Fix GCC 4.6 build warning Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC " Wolfgang Denk
2011-11-09 20:44 ` Mike Frysinger
2011-11-10 5:43 ` Wolfgang Denk
2011-11-10 16:21 ` Mike Frysinger
2011-11-10 19:07 ` Wolfgang Denk
2011-11-10 20:37 ` Anatolij Gustschin
2011-11-16 20:05 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 12/13] board/esd/cpci750/cpci750.c: Fix error handling Wolfgang Denk
2011-11-16 20:05 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 13/13] board/esd/cpci750/sdram_init.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-09 20:45 ` Mike Frysinger
2011-11-09 21:33 ` Reinhard.Arlt at t-online.de
2011-11-16 20:11 ` Wolfgang Denk
2011-11-16 20:12 ` Wolfgang Denk
2011-11-16 20:01 ` [U-Boot] [PATCH 01/13] drivers/block/sym53c8xx.c: Fix GCC 4.6 build warning Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB6FF4.5060105@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox