From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 10 Nov 2011 12:59:33 +0100 Subject: [U-Boot] [PATCH] powerpc/83xx: fix sdram initialization for keymile boards In-Reply-To: <1320921327-21855-1-git-send-email-holger.brunck@keymile.com> References: <1320921327-21855-1-git-send-email-holger.brunck@keymile.com> Message-ID: <4EBBBCA5.7070501@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Holger, Holger Brunck wrote: > From: Andreas Huber > > commit b11f53f3 (keymile: Fix Coding style issues for keymile boards) > introduces a bug according the SDRAM initialization for all > km83xx boards. > > im->ddr.sdram_cfg |= SDRAM_CFG_MEM_EN; > was replaced with > out_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); > and this is wrong, because this overwrites the intial value > CONFIG_SYS_DDR_SDRAM_CFG. > > Signed-off-by: Andreas Huber > Signed-off-by: Holger Brunck > cc: Heiko Schocher > cc: Kim Phillips > --- > board/keymile/km83xx/km83xx.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c > index 17560c8..c0238c8 100644 > --- a/board/keymile/km83xx/km83xx.c > +++ b/board/keymile/km83xx/km83xx.c > @@ -217,7 +217,8 @@ int fixed_sdram(void) > out_be32(&im->ddr.sdram_interval, CONFIG_SYS_DDR_INTERVAL); > out_be32(&im->ddr.sdram_clk_cntl, CONFIG_SYS_DDR_CLK_CNTL); > udelay(200); > - out_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); > + out_be32(&im->ddr.sdram_cfg, > + SDRAM_CFG_MEM_EN | CONFIG_SYS_DDR_SDRAM_CFG); Wouldn't a setbits_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); be better? > > msize = CONFIG_SYS_DDR_SIZE << 20; > disable_addr_trans(); bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany