From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Thu, 10 Nov 2011 15:32:54 +0100 Subject: [U-Boot] [PATCH] powerpc/83xx: fix sdram initialization for keymile boards In-Reply-To: <4EBBBCA5.7070501@denx.de> References: <1320921327-21855-1-git-send-email-holger.brunck@keymile.com> <4EBBBCA5.7070501@denx.de> Message-ID: <4EBBE096.9010304@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On 11/10/2011 12:59 PM, Heiko Schocher wrote: > Holger Brunck wrote: >> From: Andreas Huber >> >> commit b11f53f3 (keymile: Fix Coding style issues for keymile boards) >> introduces a bug according the SDRAM initialization for all >> km83xx boards. >> >> im->ddr.sdram_cfg |= SDRAM_CFG_MEM_EN; >> was replaced with >> out_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); >> and this is wrong, because this overwrites the intial value >> CONFIG_SYS_DDR_SDRAM_CFG. >> >> Signed-off-by: Andreas Huber >> Signed-off-by: Holger Brunck >> cc: Heiko Schocher >> cc: Kim Phillips >> --- >> board/keymile/km83xx/km83xx.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c >> index 17560c8..c0238c8 100644 >> --- a/board/keymile/km83xx/km83xx.c >> +++ b/board/keymile/km83xx/km83xx.c >> @@ -217,7 +217,8 @@ int fixed_sdram(void) >> out_be32(&im->ddr.sdram_interval, CONFIG_SYS_DDR_INTERVAL); >> out_be32(&im->ddr.sdram_clk_cntl, CONFIG_SYS_DDR_CLK_CNTL); >> udelay(200); >> - out_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); >> + out_be32(&im->ddr.sdram_cfg, >> + SDRAM_CFG_MEM_EN | CONFIG_SYS_DDR_SDRAM_CFG); > > Wouldn't a > > setbits_be32(&im->ddr.sdram_cfg, SDRAM_CFG_MEM_EN); > > be better? > yes this works too and is slightly nicer, I will send an updated version. Thanks! Best regards Holger