From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Thu, 10 Nov 2011 18:00:33 +0100 Subject: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver In-Reply-To: <4EBBFC15.9050107@keymile.com> References: <1320703689-4879-1-git-send-email-michael@walle.cc> <201111082330.40253.michael@walle.cc> <20111108225256.657A5189301F@gemini.denx.de> <201111090026.09460.michael@walle.cc> <0b31372341432a1daa65fa2aa3c18b35.squirrel@ssl.serverraum.org> <20111109192722.D2BDE13BE0E2@gemini.denx.de> <48935aa530a6457b76b9915a1fe7faf9.squirrel@ssl.serverraum.org> <20111110110608.GB29864@kw.sim.vm.gnt> <20111110120159.997C113BE0E2@gemini.denx.de> <20111110142152.GC29864@kw.sim.vm.gnt> <20111110155311.66DB613BE0E2@gemini.denx.de> <4EBBFC15.9050107@keymile.com> Message-ID: <4EBC0331.5010107@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/10/2011 05:30 PM, Valentin Longchamp wrote: > On 11/10/2011 04:53 PM, Wolfgang Denk wrote: >> In message <20111110142152.GC29864@kw.sim.vm.gnt> you wrote: >>> >>> I suspect a lot of Marvell boards from being in the same case. >> >> Argh... I was not aware that the scope of damage already done was that >> big. >> > > On the Keymile boards (for marvell boards, km_kirkwood) we have an EEPROM that > stores the ethaddr for each board, so we should not be affected by the removal > of this "feature" (the driver setting ethaddr). > I gave it a try on km_kirkwood. What happens on keymile boards is that we get the warning: Warning: failed to set MAC address if we initially start the board without an environment saved previously. And this is better than writing a random mac adress into the HW, I guess... Fortunately our boards in case of an initial boot are configuring different things e.g. the correct ethaddr, do a saveenv and a reboot. And afterwards everything is ok. So yes for our boards it's ok to remove this code. Best regards Holger