From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Fri, 11 Nov 2011 09:09:06 +0530 Subject: [U-Boot] [PATCH 1/2] Build u-boot.imx by default when board uses it In-Reply-To: <201111102051.46801.vapier@gentoo.org> References: <1320932982-19967-1-git-send-email-loic.minier@linaro.org> <201111101824.31539.vapier@gentoo.org> <20111110234530.GE29146@bee.dooz.org> <201111102051.46801.vapier@gentoo.org> Message-ID: <4EBC98DA.3070706@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 11 November 2011 07:21 AM, Mike Frysinger wrote: > On Thursday 10 November 2011 18:45:30 Lo?c Minier wrote: >> On Thu, Nov 10, 2011, Mike Frysinger wrote: >>>> +ifneq ($(CONFIG_IMX_CONFIG),) >>>> +ALL-y += $(obj)u-boot.imx >>>> +endif >>> >>> why won't this work: >>> ALL-$(CONFIG_IMX_CONFIG) += $(obj)u-boot.mix >>> that was the point of naming it "ALL-y" in the first place ... >> >> That's what I tried at first, but CONFIG_IMX_CONFIG is actually the >> name of the config file to pass to mkimage; same for u-boot.kwb. >> >> CONFIG_IMX_CONFIG is set in boards.cfg. > > ugly undocumented CONFIG's are awesome > > this really should be in a subdir rather than the top level. we want to keep > arch/soc-specific cruft out of the top level Makefile if possible. isn't there > a sub-config.mk somewhere you could add the line unconditionally ? This is what I have done for u-boot.img for OMAP4. arch/arm/cpu/armv7/omap4/config.mk has this: ifdef CONFIG_SPL_BUILD ALL-y += $(OBJTREE)/MLO else ALL-y += $(obj)u-boot.img endif However, this may have to be duplicated in many such config.mk files. br, Aneesh