public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/12] cosmetic: checkpatch cleanup of arch/x86/lib/*.c
Date: Sat, 12 Nov 2011 21:06:50 +1100	[thread overview]
Message-ID: <4EBE453A.2060200@gmail.com> (raw)
In-Reply-To: <1320755603-8695-5-git-send-email-graeme.russ@gmail.com>

On 08/11/11 23:33, Graeme Russ wrote:
> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
> ---
> Changes for v2:
>  - Consolidated patch series
>  - Fixed more warnings
> 
> This patch has 23 checkpatch errors all associated with asm statements
> which checkpatch does not know how to deal with
> 
> This patch has 3 checkpatch warnings, all of which are 'line over 80
> characters' which:
> 
>  - One is caused by printf() strings which, IMHO, would have reduced
>    readability if split
> 
>  - Two are due to calculations which could be shortened by converting the
>    x86 zImage/bzImage header offsets into a structure (which should be done
>    on principle anyway) - This is a big change prone to the introduction of
>    bugs and will, therefore, be done later after the current x86 backlog
>    stabilises
> 
>  arch/x86/include/asm/pci.h        |    3 +
>  arch/x86/include/asm/realmode.h   |    4 +
>  arch/x86/include/asm/u-boot-x86.h |    8 ++
>  arch/x86/lib/bios.h               |  201 ++++++++++++++++++++++++++-----------
>  arch/x86/lib/bios_pci.S           |   92 ++++++++++++------
>  arch/x86/lib/bios_setup.c         |   93 +++--------------
>  arch/x86/lib/board.c              |  114 ++++++++++-----------
>  arch/x86/lib/bootm.c              |   23 ++--
>  arch/x86/lib/interrupts.c         |   20 ++--
>  arch/x86/lib/pcat_interrupts.c    |    2 +-
>  arch/x86/lib/pcat_timer.c         |   37 ++++----
>  arch/x86/lib/pci.c                |   63 ++++++------
>  arch/x86/lib/pci_type1.c          |    9 +-
>  arch/x86/lib/realmode.c           |   20 ++--
>  arch/x86/lib/timer.c              |   16 ++--
>  arch/x86/lib/video.c              |    6 +-
>  arch/x86/lib/video_bios.c         |  143 +++++++++++++++------------
>  arch/x86/lib/zimage.c             |   94 ++++++++++--------
>  18 files changed, 516 insertions(+), 432 deletions(-)

Applied to u-boot-x86

Thanks,

Graeme

  reply	other threads:[~2011-11-12 10:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06 11:54 [U-Boot] [PATCH 0/5] x86: Cosmetic cleanup Graeme Russ
2011-11-06 11:54 ` [U-Boot] [PATCH 1/5] x86: Call hang() on unrecoverable exception Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 01/12] " Graeme Russ
2011-11-12 10:05     ` Graeme Russ
2011-11-06 11:54 ` [U-Boot] [PATCH 2/5] cosmetic: checkpatch cleanup arch/x86/cpu/*.c Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 02/12] cosmetic: checkpatch cleanup of arch/x86/cpu/*.c Graeme Russ
2011-11-12 10:05     ` Graeme Russ
2011-11-06 11:54 ` [U-Boot] [PATCH 3/5] cosmetic: checkpatch cleanup arch/x86/cpu/sc520/*.c Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 03/12] cosmetic: checkpatch cleanup of arch/x86/cpu/sc520/*.c Graeme Russ
2011-11-12 10:06     ` Graeme Russ
2011-11-06 11:54 ` [U-Boot] [PATCH 4/5] cosmetic: checkpatch cleanup of arch/x86/lib/*.c Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 04/12] " Graeme Russ
2011-11-12 10:06     ` Graeme Russ [this message]
2011-11-06 11:54 ` [U-Boot] [PATCH 5/5] cosmetic: checkpatch cleanup of board/eNET/*.c Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 05/12] " Graeme Russ
2011-11-12 10:07     ` Graeme Russ
2011-11-08 12:33 ` [U-Boot] [PATCH v2 00/12] x86: Various cosmetic and minor code fixups Graeme Russ
2011-11-08 12:43   ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBE453A.2060200@gmail.com \
    --to=graeme.russ@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox