From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Sat, 12 Nov 2011 21:22:27 +1100 Subject: [U-Boot] [PATCH] [x86] [zboot] Change printf to puts to avoid a buffer overflow In-Reply-To: <1320744101-32666-1-git-send-email-gabeblack@chromium.org> References: <1320744101-32666-1-git-send-email-gabeblack@chromium.org> Message-ID: <4EBE48E3.8070606@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gabe, On 08/11/11 20:21, Gabe Black wrote: > printf as currently implemented in u-boot has a problem where it can > overflow an internal buffer if it prints an expanded string that's too > long. Our command lines are long enough to cause this problem. A fix > should be coming, but in the mean time this change replaces a problematic > printf with a few calls to puts that have the same effect. This may perform > slightly better because it should avoid a copy and scanning for format > specifiers. The amount of time it actually takes up is very tiny relative > to everything else so in practice that's probably irrelevant. > > Signed-off-by: Gabe Black > --- > arch/x86/lib/zimage.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Can you please rebase against u-boot-x86/master and re-submit While you're at it, please change tag to 'x86:' style Thanks, Graeme