From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] x86: Import the glibc memset implementation
Date: Sun, 13 Nov 2011 22:38:17 +1100 [thread overview]
Message-ID: <4EBFAC29.4070609@gmail.com> (raw)
In-Reply-To: <1321153238-19766-1-git-send-email-gabeblack@chromium.org>
Hi Gabe,
Sorry about the lateness, but I just noticed a couple of issues..
Can you put the glibc version in the patch summary? I know it is in
string.c, but including it in the summary makes it more obvious.
On 13/11/11 14:00, Gabe Black wrote:
> The new implementation is about twice as fast as the old.
>
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
[snip]
> diff --git a/arch/x86/lib/string.c b/arch/x86/lib/string.c
> new file mode 100644
> index 0000000..1346173
> --- /dev/null
> +++ b/arch/x86/lib/string.c
> @@ -0,0 +1,87 @@
> +/*
> + * Copyright (C) 1991,1992,1993,1997,1998,2003, 2005 Free Software Foundation, Inc.
Line over 80 characters - I can live with this as it is a verbatim import
> + * This file is part of the GNU C Library.
> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
This, however, causes a problem - There is some conjecture as to whether
"All rights reserved" can co-exist with GPL. I believe there is a mandate
from Wolfgang to not accept patches with this clause - Do I understand
correctly Wolfgang?
Regards,
Graeme
next prev parent reply other threads:[~2011-11-13 11:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 9:59 [U-Boot] [PATCH] Import the glibc implementation of x86 memset into u-boot Gabe Black
2011-11-08 13:49 ` Mike Frysinger
2011-11-08 22:40 ` [U-Boot] [PATCH v2] x86: Import the glibc memset implementation Gabe Black
2011-11-09 0:45 ` Graeme Russ
2011-11-09 0:59 ` Gabe Black
2011-11-09 1:10 ` Graeme Russ
2011-11-09 1:15 ` Gabe Black
2011-11-09 1:25 ` Graeme Russ
2011-11-09 1:52 ` Gabe Black
2011-11-09 2:53 ` Graeme Russ
2011-11-09 4:55 ` Mike Frysinger
2011-11-09 4:04 ` Gabe Black
2011-11-09 19:12 ` Scott Wood
2011-11-09 20:47 ` Mike Frysinger
2011-11-12 6:19 ` Gabe Black
2011-11-12 9:20 ` Graeme Russ
2011-11-09 6:01 ` Graeme Russ
2011-11-09 5:36 ` Wolfgang Denk
2011-11-09 5:50 ` Graeme Russ
2011-11-12 10:28 ` [U-Boot] [PATCH] Import the glibc implementation of x86 memset into u-boot Graeme Russ
2011-11-13 3:00 ` [U-Boot] [PATCH v3] x86: Import the glibc memset implementation Gabe Black
2011-11-13 11:38 ` Graeme Russ [this message]
2011-11-14 12:38 ` Gabe Black
2011-11-14 21:49 ` Graeme Russ
2011-11-15 0:42 ` Gabe Black
2011-11-15 0:47 ` [U-Boot] [PATCH v4] " Gabe Black
2011-11-30 11:05 ` Graeme Russ
2011-11-14 16:48 ` [U-Boot] [PATCH v3] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBFAC29.4070609@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox