* [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default
@ 2011-11-08 9:09 Gabe Black
2011-11-08 13:47 ` Mike Frysinger
2011-11-13 17:05 ` Jerry Van Baren
0 siblings, 2 replies; 4+ messages in thread
From: Gabe Black @ 2011-11-08 9:09 UTC (permalink / raw)
To: u-boot
The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a
const void * for its fdt argument.
Signed-off-by: Gabe Black <gabeblack@chromium.org>
---
common/fdt_support.c | 4 ++--
include/fdt_support.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index bdda64d..bd3a014 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
* Convenience function to find a node and return it's property or a
* default value if it doesn't exist.
*/
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
- const u32 dflt)
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+ const char *prop, const u32 dflt)
{
const u32 *val;
int off;
diff --git a/include/fdt_support.h b/include/fdt_support.h
index c7b4605..cef3c65 100644
--- a/include/fdt_support.h
+++ b/include/fdt_support.h
@@ -28,8 +28,8 @@
#include <fdt.h>
-u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
- const u32 dflt);
+u32 fdt_getprop_u32_default(const void *fdt, const char *path,
+ const char *prop, const u32 dflt);
int fdt_chosen(void *fdt, int force);
int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int force);
void do_fixup_by_path(void *fdt, const char *path, const char *prop,
--
1.7.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default
2011-11-08 9:09 [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default Gabe Black
@ 2011-11-08 13:47 ` Mike Frysinger
2011-11-13 2:07 ` Gabe Black
2011-11-13 17:05 ` Jerry Van Baren
1 sibling, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2011-11-08 13:47 UTC (permalink / raw)
To: u-boot
+fdt maintainer
On Tuesday 08 November 2011 04:09:44 Gabe Black wrote:
> The function fdt_getprop_u32_default doesn't modify the fdt, so it can use
> a const void * for its fdt argument.
>
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
> common/fdt_support.c | 4 ++--
> include/fdt_support.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index bdda64d..bd3a014 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
> * Convenience function to find a node and return it's property or a
> * default value if it doesn't exist.
> */
> -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
> - const u32 dflt)
> +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> + const char *prop, const u32 dflt)
> {
> const u32 *val;
> int off;
> diff --git a/include/fdt_support.h b/include/fdt_support.h
> index c7b4605..cef3c65 100644
> --- a/include/fdt_support.h
> +++ b/include/fdt_support.h
> @@ -28,8 +28,8 @@
>
> #include <fdt.h>
>
> -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
> - const u32 dflt);
> +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> + const char *prop, const u32 dflt);
> int fdt_chosen(void *fdt, int force);
> int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int
> force); void do_fixup_by_path(void *fdt, const char *path, const char
> *prop,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111108/e19d79cf/attachment.pgp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default
2011-11-08 13:47 ` Mike Frysinger
@ 2011-11-13 2:07 ` Gabe Black
0 siblings, 0 replies; 4+ messages in thread
From: Gabe Black @ 2011-11-13 2:07 UTC (permalink / raw)
To: u-boot
Bump.
On Tue, Nov 8, 2011 at 5:47 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> +fdt maintainer
>
> On Tuesday 08 November 2011 04:09:44 Gabe Black wrote:
> > The function fdt_getprop_u32_default doesn't modify the fdt, so it can
> use
> > a const void * for its fdt argument.
> >
> > Signed-off-by: Gabe Black <gabeblack@chromium.org>
> > ---
> > common/fdt_support.c | 4 ++--
> > include/fdt_support.h | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/common/fdt_support.c b/common/fdt_support.c
> > index bdda64d..bd3a014 100644
> > --- a/common/fdt_support.c
> > +++ b/common/fdt_support.c
> > @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
> > * Convenience function to find a node and return it's property or a
> > * default value if it doesn't exist.
> > */
> > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char
> *prop,
> > - const u32 dflt)
> > +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> > + const char *prop, const u32 dflt)
> > {
> > const u32 *val;
> > int off;
> > diff --git a/include/fdt_support.h b/include/fdt_support.h
> > index c7b4605..cef3c65 100644
> > --- a/include/fdt_support.h
> > +++ b/include/fdt_support.h
> > @@ -28,8 +28,8 @@
> >
> > #include <fdt.h>
> >
> > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char
> *prop,
> > - const u32 dflt);
> > +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> > + const char *prop, const u32 dflt);
> > int fdt_chosen(void *fdt, int force);
> > int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int
> > force); void do_fixup_by_path(void *fdt, const char *path, const char
> > *prop,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default
2011-11-08 9:09 [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default Gabe Black
2011-11-08 13:47 ` Mike Frysinger
@ 2011-11-13 17:05 ` Jerry Van Baren
1 sibling, 0 replies; 4+ messages in thread
From: Jerry Van Baren @ 2011-11-13 17:05 UTC (permalink / raw)
To: u-boot
On 11/08/2011 04:09 AM, Gabe Black wrote:
> The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a
> const void * for its fdt argument.
>
> Signed-off-by: Gabe Black<gabeblack@chromium.org>
Applied and requested a bugfix pull.
Thanks,
gvb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-13 17:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08 9:09 [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default Gabe Black
2011-11-08 13:47 ` Mike Frysinger
2011-11-13 2:07 ` Gabe Black
2011-11-13 17:05 ` Jerry Van Baren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox