From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] smsc95xx: remove an unecessary debug messages
Date: Mon, 14 Nov 2011 09:33:05 +0100 [thread overview]
Message-ID: <4EC0D241.5080403@grandegger.com> (raw)
In-Reply-To: <CAPnjgZ2aL9ziHe7dMiCsM0egvXfQP2W7uaHyPHvAxTp95XBhHw@mail.gmail.com>
On 11/11/2011 04:26 PM, Simon Glass wrote:
> Hi Wolfgang,
>
> On Fri, Nov 11, 2011 at 2:59 AM, Wolfgang Grandegger <wg@denx.de> wrote:
>> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>> drivers/usb/eth/smsc95xx.c | 7 +++----
>> 1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
>> index 16e24bd..40f7f5b 100644
>> --- a/drivers/usb/eth/smsc95xx.c
>> +++ b/drivers/usb/eth/smsc95xx.c
>> @@ -380,15 +380,14 @@ static int smsc95xx_write_hwaddr(struct eth_device *eth)
>> /* set hardware address */
>> debug("** %s()\n", __func__);
>>
>> - ret = smsc95xx_write_reg(dev, ADDRL, addr_lo);
>> - if (ret < 0) {
>> - debug("Failed to write ADDRL: %d\n", ret);
>> + ret = smsc95xx_write_reg(dev, ADDRL, adddr_lo);
>
> addr_lo?
Oh yeah, sneaked in somehow, sorry ... I'm now focusing on Mike's patch
fixing the same issue. Hope to have some feedback later today.
Wolfgang.
prev parent reply other threads:[~2011-11-14 8:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 10:59 [U-Boot] [PATCH 0/3] smsc95xx: Fix MAC address programming and some minor issues Wolfgang Grandegger
2011-11-11 10:59 ` [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming Wolfgang Grandegger
2011-11-11 11:04 ` Marek Vasut
2011-11-11 12:33 ` Wolfgang Grandegger
2011-11-11 15:18 ` Mike Frysinger
2011-11-14 8:25 ` Wolfgang Grandegger
2011-11-14 16:50 ` Mike Frysinger
2011-11-15 9:25 ` Wolfgang Grandegger
2011-11-11 15:20 ` Mike Frysinger
2011-11-11 15:22 ` Mike Frysinger
2011-11-11 10:59 ` [U-Boot] [PATCH 2/3] smsc95xx: in smsc95xx_set_multicast write to reg Wolfgang Grandegger
2011-11-11 15:35 ` Simon Glass
2011-11-14 12:18 ` Wolfgang Grandegger
2011-11-14 20:06 ` Simon Glass
2011-11-11 10:59 ` [U-Boot] [PATCH 3/3] smsc95xx: remove an unecessary debug messages Wolfgang Grandegger
2011-11-11 15:26 ` Simon Glass
2011-11-14 8:33 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC0D241.5080403@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox