From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] mx5: add generic USB EHCI support for mx51 and mx53
Date: Mon, 14 Nov 2011 09:39:32 +0100 [thread overview]
Message-ID: <4EC0D3C4.2000308@grandegger.com> (raw)
In-Reply-To: <CAOMZO5B6BGUT21XswyyAsfW31CoFZbAAiBvv07movup==b=wQQ@mail.gmail.com>
On 11/11/2011 03:22 PM, Fabio Estevam wrote:
> Hi Wolfgang,
>
> On Fri, Nov 11, 2011 at 11:03 AM, Wolfgang Grandegger <wg@denx.de> wrote:
>> It's derived from ehci-mxc and uses the header files of the
>> ehci-fsl interface. The callback board_ehci_hcd_init() has
>> been introduced to allow for board-specific setup when USB
>> is started.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
>> CC: Stefano Babic <sbabic@denx.de>
>> CC: Remy Bohmer <linux@bohmer.net>
>> ---
>> drivers/usb/host/Makefile | 1 +
>> drivers/usb/host/ehci-mx5.c | 174 +++++++++++++++++++++++++++++++++++++++++++
>> include/usb/ehci-fsl.h | 10 +++
>> 3 files changed, 185 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/usb/host/ehci-mx5.c
>
> Do we really need to create a drivers/usb/host/ehci-mx5.c?
>
> Can't mx5 USB support be included inside drivers/usb/host/ehci-mxc.c instead?
it could be included into ehci-mxc.c using #ifdef's, of course. Would
that be the better solution?
Wolfgang.
next prev parent reply other threads:[~2011-11-14 8:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 13:03 [U-Boot] [PATCH 0/5] mx5: USB host support for mx51evk and mx53loco Wolfgang Grandegger
2011-11-11 13:03 ` [U-Boot] [PATCH 1/5] mx5: add helper functions to enable USB clocks Wolfgang Grandegger
2011-11-11 13:03 ` [U-Boot] [PATCH 2/5] mx5: add helper function to retrieve the GPIO number Wolfgang Grandegger
2011-11-11 13:03 ` [U-Boot] [PATCH 3/5] mx5: add generic USB EHCI support for mx51 and mx53 Wolfgang Grandegger
2011-11-11 14:22 ` Fabio Estevam
2011-11-14 8:39 ` Wolfgang Grandegger [this message]
2011-11-11 13:03 ` [U-Boot] [PATCH 4/5] mx53loco: add end enable USB host support on port 1 Wolfgang Grandegger
2011-11-16 7:22 ` Jason Liu
2011-11-24 3:01 ` Marek Vasut
2011-11-11 13:03 ` [U-Boot] [PATCH 5/5] mx51evk: " Wolfgang Grandegger
2011-11-11 21:44 ` [U-Boot] [PATCH 0/5] mx5: USB host support for mx51evk and mx53loco Marek Vasut
2011-11-14 8:50 ` Wolfgang Grandegger
2011-11-14 10:46 ` Marek Vasut
2011-11-14 10:55 ` Wolfgang Grandegger
2011-11-11 23:34 ` Jana Rapava
2011-11-14 9:01 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC0D3C4.2000308@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox