From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 14 Nov 2011 12:28:11 +0100 Subject: [U-Boot] [PATCH 1/6] i.mx: i.mx5: Move some files to imx-common folder In-Reply-To: References: <1321094190-8108-1-git-send-email-jason.hui@linaro.org> <1321094190-8108-2-git-send-email-jason.hui@linaro.org> <4EC0D278.4020408@denx.de> Message-ID: <4EC0FB4B.2040003@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/14/2011 09:57 AM, Jason Hui wrote: > > Yes, agree. what about cpu.c? if you dislike, could you do me a favor > to name it. :) Agree - let's change it into cpu.c ! >> >> You mix here two things - you move the files and you change it adding >> new features. Split into two patches. > > In fact, I did not do any function change. I just do the followings two changes: > > - fix the checkpatch warnings with the original timer.c file in mx5 folder. > - change the CONFIG_SYS_MX5_CLK32 to CLK_32KHZ > > I can add the changes to the commit message. Do I still need split > into two patches? No, you have better explained what you did - it is ok for me if you extend the commit message. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================