public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 3/4] tegra2: Modify MMC driver to handle power and cd GPIOs
Date: Tue, 15 Nov 2011 14:51:12 -0700	[thread overview]
Message-ID: <4EC2DED0.60400@nvidia.com> (raw)
In-Reply-To: <CAKWjMd519_FyhCkXpZTqajFsE0adsT2TB4mDhTmcdQO6zznuYQ@mail.gmail.com>

On 11/02/2011 08:30 PM, Andy Fleming wrote:
> On Mon, Oct 31, 2011 at 11:51 AM, Stephen Warren <swarren@nvidia.com> wrote:
>> Pass the GPIO numbers for power and card detect to tegra2_mmc_init(), and
>> modify that function to perform all required GPIO initialization. This
>> removes the need for board files to perform these operations.
>>
>> Move board_mmc_getcd() into tegra2_mmc.c now that the driver knows which
>> GPIOs to use.
>>
>> Update affected call-sites in seaboard.c and harmony.c. Note that this
>> change should make all SD ports work on Harmony, since the required GPIO
>> setup is now being performed.
>>
>> v4: Fix prototype of tegra2_mmc_init() in board.h to match driver change.
>>    Remove prototype of gpio_config_mmc() from board.h
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> Cc: Andy Fleming <afleming@gmail.com>
>> Tested-by: Simon Glass <sjg@chromium.org>
>> Acked-by: Simon Glass <sjg@chromium.org>
> 
> This patch depends heavily on patch #2 (ie, won't apply without it),
> which doesn't touch drivers/mmc.
> 
> Lacking an ACK from Albert, I hesitate to just apply the whole series.
> I've applied patch #1, and I'll let Albert decide whether to apply the
> other 3:
> 
> Acked-by: Andy Fleming <afleming@freescale.com>
> 
> I have also re-assigned this patch in patchworks to Albert.

Albert, Do the remaining 3 patches in this series look good?

Thanks.

-- 
nvpublic

  reply	other threads:[~2011-11-15 21:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 16:51 [U-Boot] [PATCH v7 1/4] tegra2: Move MMC clock initialization into MMC driver Stephen Warren
2011-10-31 16:51 ` [U-Boot] [PATCH v7 2/4] tegra2: Move board_mmc_init into board files Stephen Warren
2011-10-31 16:51 ` [U-Boot] [PATCH v7 3/4] tegra2: Modify MMC driver to handle power and cd GPIOs Stephen Warren
2011-11-03  2:30   ` Andy Fleming
2011-11-15 21:51     ` Stephen Warren [this message]
2011-10-31 16:51 ` [U-Boot] [PATCH v7 4/4] tegra2: Add support for Ventana Stephen Warren
2011-10-31 18:08 ` [U-Boot] [PATCH v7 1/4] tegra2: Move MMC clock initialization into MMC driver Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC2DED0.60400@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox