public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: davici_emac: Fix condition for number of phy	detects
Date: Thu, 17 Nov 2011 14:04:01 +0100	[thread overview]
Message-ID: <4EC50641.3040307@denx.de> (raw)
In-Reply-To: <1321534403-11839-1-git-send-email-prabhakar.csengg@gmail.com>

Hello prabhakar.csengg at gmail.com

prabhakar.csengg at gmail.com wrote:
> From: Prabhakar Lad <prabhakar.csengg@gmail.com>
> 
> Fix the condition for number of phys in
> davinci_eth_phy_detect() function.
> CONFIG_SYS_DAVINCI_EMAC_PHY_COUNT indicates number of
> phys. From this commit id dc02badab480563b0bf9d3908046ea9d6b22ae63
> davinci emac initilazed one less than the number of phy count.
> 
> Signed-off-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
> ---
>  drivers/net/davinci_emac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 36c33af..34b6f94 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -176,7 +176,7 @@ static int davinci_eth_phy_detect(void)
>  	for (i = 0, j = 0; i < 32; i++)
>  		if (phy_act_state & (1 << i)) {
>  			count++;
> -			if (count < CONFIG_SYS_DAVINCI_EMAC_PHY_COUNT) {
> +			if (count <= CONFIG_SYS_DAVINCI_EMAC_PHY_COUNT) {
>  				active_phy_addr[j++] = i;
>  			} else {
>  				printf("%s: to many PHYs detected.\n",

good catch!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2011-11-17 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 12:53 [U-Boot] [PATCH] ARM: davici_emac: Fix condition for number of phy detects prabhakar.csengg at gmail.com
2011-11-17 13:04 ` Heiko Schocher [this message]
2011-11-29  4:30   ` Prabhakar Lad
2011-11-29 20:38     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC50641.3040307@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox