From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 17 Nov 2011 15:12:33 +0100 Subject: [U-Boot] [PATCH 03/17] env: move extern default_environment[] to environment.h In-Reply-To: <1320664451-2678-4-git-send-email-grinberg@compulab.co.il> References: <1320664451-2678-1-git-send-email-grinberg@compulab.co.il> <1320664451-2678-4-git-send-email-grinberg@compulab.co.il> Message-ID: <4EC51651.7020805@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/07/2011 12:13 PM, Igor Grinberg wrote: > Extract all extern declarations for default_environment[] out of c files > into the environment.h header. > > Signed-off-by: Igor Grinberg > Cc: Stefan Roese > --- > board/zeus/zeus.c | 1 - > common/env_dataflash.c | 2 -- > common/env_flash.c | 2 -- > common/env_mgdisk.c | 3 --- > common/env_mmc.c | 3 --- > common/env_nand.c | 3 --- > common/env_nowhere.c | 2 -- > common/env_nvram.c | 2 -- > common/env_onenand.c | 3 --- > common/env_sf.c | 3 --- > include/environment.h | 2 ++ > 11 files changed, 2 insertions(+), 24 deletions(-) > Hi Igor, this patch breaks several boards because "tools" cannot be compiled clean: gcc -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -idirafter /home/stefano/Projects/u-boot-staging/include -idirafter /home/stefano/Projects/u-boot-staging/include2 -idirafter /home/stefano/Projects/u-boot-staging/include -I /home/stefano/Projects/u-boot-staging/lib/libfdt -I /home/stefano/Projects/u-boot-staging/tools -DCONFIG_SYS_TEXT_BASE=0x02000000 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -pedantic -o envcrc.o envcrc.c -c envcrc.c:80:1: Fehler: unbekannter Typname: ?env_t? make[1]: *** [envcrc.o] Fehler 1 You can try with the cmi_mpc5xx board, but it is only an example - I get the same errors with several ARM boards, because at the end environment.h is not included. Can you take a look at it ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================