From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: allow to export only selected variables
Date: Thu, 17 Nov 2011 19:47:23 +0100 [thread overview]
Message-ID: <4EC556BB.7030600@keymile.com> (raw)
In-Reply-To: <1320754970-26150-1-git-send-email-wd@denx.de>
Dear Wolfgang Denk,
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -125,7 +125,7 @@ static int env_print(char *name)
> }
>
> /* print whole list */
> - len = hexport_r(&env_htab, '\n',&res, 0);
> + len = hexport_r(&env_htab, '\n',&res, 0, 0, NULL);
>
> if (len> 0) {
> puts(res);
Here you extended the function signature by adding 2 new arguments and
therefore you had to touch 12 existing function calls so to add the
default values for the new args.
In my previous patches, I had renamed the sibling himport_r() function
to himport_ex() with the 2 extra args and reimplemented himport_r() as a
wrapper, so to maintain compatibility with the existing code.
Just to realize now that, after some reworking, there is only one
function call to the original himport_r() left.
I'm going to get rid of this renaming.
I mean: completely opposite approaches... funny, huh?
Best,
Gerlando Falauto
next prev parent reply other threads:[~2011-11-17 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 12:22 [U-Boot] [PATCH] env: allow to export only selected variables Wolfgang Denk
2011-11-17 18:47 ` Gerlando Falauto [this message]
2011-11-17 19:06 ` Gerlando Falauto
2011-11-17 19:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC556BB.7030600@keymile.com \
--to=gerlando.falauto@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox