From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 06/12] OMAP3: Suffix all Micron memory timing parts with their speed
Date: Thu, 17 Nov 2011 14:50:46 -0700 [thread overview]
Message-ID: <4EC581B6.8080101@ti.com> (raw)
In-Reply-To: <4EBB6DDF.3030400@denx.de>
On 11/09/2011 11:23 PM, Heiko Schocher wrote:
> Hello Tom,
>
> Tom Rini wrote:
[snip]
>> +#define MICRON_V_MCFG_165 ((MICRON_LOCKSTATUS_165 << 30) | \
> ^
> Please substitute this magic values in this patch by an define.
OK, what I've got now is a macro to calculate the MCFG values based on a
few inputs. What I don't think helps readability is doing:
#define V_MCFG_CASWIDTH_SHIFT 20
#define V_MCFG_CASWIDTH (0x3 << V_MCFG_CASWIDTH_SHIFT)
when
#define V_MCFG_CASWIDTH (0x3 << 20) /* 20:23 */
will do.
It can make sense in places where it's not otherwise clear why you're
doing a shift but in these cases
--
Tom
next prev parent reply other threads:[~2011-11-17 21:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 17:10 [U-Boot] [PATCH v3 0/12] Add more framework to OMAP3 SPL, port more boards Tom Rini
2011-11-09 17:10 ` [U-Boot] [PATCH v3 01/12] OMAP3: Update SDRC dram_init to always call make_cs1_contiguous() Tom Rini
2011-11-09 17:10 ` [U-Boot] [PATCH v3 02/12] OMAP3: Add a helper function to set timings in SDRC Tom Rini
2011-11-09 17:10 ` [U-Boot] [PATCH v3 03/12] OMAP3: Change mem_ok to clear again after reading back Tom Rini
2011-11-09 17:10 ` [U-Boot] [PATCH v3 04/12] OMAP3: Remove get_mem_type prototype Tom Rini
2011-11-09 17:10 ` [U-Boot] [PATCH v3 05/12] OMAP3: Add optimal SDRC autorefresh control values Tom Rini
2011-11-10 6:20 ` Heiko Schocher
2011-11-10 21:32 ` Robert Hurdle
2011-11-17 21:44 ` Tom Rini
2011-11-09 17:11 ` [U-Boot] [PATCH v3 06/12] OMAP3: Suffix all Micron memory timing parts with their speed Tom Rini
2011-11-10 6:23 ` Heiko Schocher
2011-11-17 21:50 ` Tom Rini [this message]
2011-11-09 17:11 ` [U-Boot] [PATCH v3 07/12] OMAP3 SPL: Rework memory initalization and devkit8000 support Tom Rini
2011-11-09 17:11 ` [U-Boot] [PATCH v3 08/12] OMAP3 SPL: Add identify_nand_chip function Tom Rini
2011-11-10 6:25 ` Heiko Schocher
2011-11-17 22:36 ` Tom Rini
2011-11-09 17:11 ` [U-Boot] [PATCH v3 09/12] OMAP3: Add SPL support to Beagleboard Tom Rini
2011-11-10 6:28 ` Heiko Schocher
2011-11-10 14:34 ` Tom Rini
2011-11-10 14:46 ` Heiko Schocher
2011-11-09 17:11 ` [U-Boot] [PATCH v3 10/12] OMAP3: Add SPL support to omap3_evm Tom Rini
2011-11-09 17:11 ` [U-Boot] [PATCH v3 11/12] AM3517: Add SPL support Tom Rini
2011-11-09 17:11 ` [U-Boot] [PATCH v3 12/12] AM3517 CraneBoard: " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC581B6.8080101@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox