public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] checkpatch compliance
Date: Fri, 18 Nov 2011 08:25:05 +0100	[thread overview]
Message-ID: <4EC60851.9040706@keymile.com> (raw)
In-Reply-To: <20111117205404.9105F140874F@gemini.denx.de>

On 11/17/2011 09:54 PM, Wolfgang Denk wrote:
> Dear Gerlando Falauto,
>
> In message<4EC56A2E.2000708@keymile.com>  you wrote:
>>
>> What is wrong with something like:
>>
>> ERROR: do not initialise statics to 0 or NULL
>> #35: FILE: serial.c:32:
>> +static struct serial_device *serial_devices = NULL;
 >
> Why?  Why don't you just follow the advise and remove the redundant
> initializers?

Sorry, I didn't realize it had to do with redundancy, the message was 
somewhat unclear to me.
I thought the complaint meant something like "you should initialize 
statics somewhere else", which, in fact, would not make any sense, in 
ANY context.

I personally would prefer an explicit initialization though, like mama 
told me to ALWAYS do... wash your hands before you eat, brush your teeth 
after. (I also like to believe I'm not the only one who had never read 
ISO/IEC 9899 ?6.7.8#2). :-)

Thanks,
Gerlando Falauto

  reply	other threads:[~2011-11-18  7:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 22:28 [U-Boot] checkpatch compliance Joe Hershberger
2011-10-09 19:22 ` Wolfgang Denk
2011-10-12  1:41   ` [U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools Joe Hershberger
2011-10-13  2:54     ` Xiangfu Liu
2011-10-13  3:27     ` Mike Frysinger
2011-10-13 17:25       ` Joe Hershberger
2011-10-13 18:20         ` Mike Frysinger
2011-10-13 18:30           ` Joe Hershberger
2011-10-13 19:01             ` Mike Frysinger
2011-10-18 20:06     ` [U-Boot] [PATCH v2] " Joe Hershberger
2011-10-19 18:28       ` Joe Hershberger
2011-11-17 13:28       ` Wolfgang Denk
2011-10-12  1:42   ` [U-Boot] checkpatch compliance Joe Hershberger
2011-10-12  3:59   ` Mike Frysinger
2011-10-12  7:36     ` Wolfgang Denk
2011-10-12 17:57       ` Mike Frysinger
2011-10-12 18:41         ` Wolfgang Denk
2011-10-12 19:24           ` Mike Frysinger
2011-10-13 23:03           ` [U-Boot] [PATCH 1/2] common: cosmetic: CONFIG_ROOTPATH " Joe Hershberger
2011-10-13 22:34             ` Mike Frysinger
2011-10-21 23:21             ` Wolfgang Denk
2011-10-13 23:03           ` [U-Boot] [PATCH 2/2] common: cosmetic: CONFIG_BOOTFILE " Joe Hershberger
2011-10-13 22:34             ` Mike Frysinger
2011-10-13 22:41               ` Joe Hershberger
2011-10-21 23:21             ` Wolfgang Denk
2011-10-13  0:56   ` [U-Boot] " Joe Hershberger
2011-10-13  1:03     ` Mike Frysinger
2011-10-13 17:14       ` Joe Hershberger
2011-10-13 18:19         ` Mike Frysinger
2011-10-13 20:36     ` Wolfgang Denk
2011-11-17 20:10 ` Gerlando Falauto
2011-11-17 20:54   ` Wolfgang Denk
2011-11-18  7:25     ` Gerlando Falauto [this message]
2011-11-17 21:33   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC60851.9040706@keymile.com \
    --to=gerlando.falauto@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox