* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
@ 2011-09-15 5:34 Heiko Schocher
2011-11-21 12:57 ` Holger Brunck
2011-11-22 21:00 ` Mike Frysinger
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Schocher @ 2011-09-15 5:34 UTC (permalink / raw)
To: u-boot
Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
post/post.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/post/post.c b/post/post.c
index 6c59f91..0bfca75 100644
--- a/post/post.c
+++ b/post/post.c
@@ -488,7 +488,7 @@ void post_reloc(void)
*/
unsigned long post_time_ms(unsigned long base)
{
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
- base;
#else
--
1.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
2011-09-15 5:34 [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm Heiko Schocher
@ 2011-11-21 12:57 ` Holger Brunck
2011-11-21 14:09 ` Heiko Schocher
2011-11-22 21:00 ` Mike Frysinger
1 sibling, 1 reply; 6+ messages in thread
From: Holger Brunck @ 2011-11-21 12:57 UTC (permalink / raw)
To: u-boot
Hi Heiko,
On 09/15/2011 07:34 AM, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> post/post.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/post/post.c b/post/post.c
> index 6c59f91..0bfca75 100644
> --- a/post/post.c
> +++ b/post/post.c
> @@ -488,7 +488,7 @@ void post_reloc(void)
> */
> unsigned long post_time_ms(unsigned long base)
> {
> -#ifdef CONFIG_PPC
> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
> return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
> - base;
> #else
this commit breaks post test support for our keymile arm boards:
> make km_kirkwood
[...]
post/libpost.o: In function `post_time_ms':
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_ticks'
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_tbclk'
So it seems that the kirkwood code has no implementation for these functions.
Any idea how to fix this?
Best regards
Holger
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
2011-11-21 12:57 ` Holger Brunck
@ 2011-11-21 14:09 ` Heiko Schocher
2011-11-21 14:27 ` Holger Brunck
2011-11-22 8:26 ` Prafulla Wadaskar
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Schocher @ 2011-11-21 14:09 UTC (permalink / raw)
To: u-boot
Hello Holger,
added Prafulla Wadaskar to cc ...
Holger Brunck wrote:
> Hi Heiko,
>
> On 09/15/2011 07:34 AM, Heiko Schocher wrote:
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> ---
>> post/post.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/post/post.c b/post/post.c
>> index 6c59f91..0bfca75 100644
>> --- a/post/post.c
>> +++ b/post/post.c
>> @@ -488,7 +488,7 @@ void post_reloc(void)
>> */
>> unsigned long post_time_ms(unsigned long base)
>> {
>> -#ifdef CONFIG_PPC
>> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
>> return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
>> - base;
>> #else
>
> this commit breaks post test support for our keymile arm boards:
:-(
I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support
worked for you before this patch? You should have seen this warning message:
#warning "Not implemented yet"
or?
>> make km_kirkwood
> [...]
> post/libpost.o: In function `post_time_ms':
> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_ticks'
> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_tbclk'
>
> So it seems that the kirkwood code has no implementation for these functions.
> Any idea how to fix this?
We must implement it ... Prafulla, can you comment this?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
2011-11-21 14:09 ` Heiko Schocher
@ 2011-11-21 14:27 ` Holger Brunck
2011-11-22 8:26 ` Prafulla Wadaskar
1 sibling, 0 replies; 6+ messages in thread
From: Holger Brunck @ 2011-11-21 14:27 UTC (permalink / raw)
To: u-boot
Hi Heiko,
On 11/21/2011 03:09 PM, Heiko Schocher wrote:
> Holger Brunck wrote:
>> On 09/15/2011 07:34 AM, Heiko Schocher wrote:
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> ---
>>> post/post.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/post/post.c b/post/post.c
>>> index 6c59f91..0bfca75 100644
>>> --- a/post/post.c
>>> +++ b/post/post.c
>>> @@ -488,7 +488,7 @@ void post_reloc(void)
>>> */
>>> unsigned long post_time_ms(unsigned long base)
>>> {
>>> -#ifdef CONFIG_PPC
>>> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
>>> return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
>>> - base;
>>> #else
>>
>> this commit breaks post test support for our keymile arm boards:
>
> :-(
>
> I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support
I guess that our post support wasn't mainlined at the time you test the patch.
> worked for you before this patch? You should have seen this warning message:
>
> #warning "Not implemented yet"
>
> or?
>
Yes we got these warning in the past but this wasn't a problem for us, because
we don't use these timer informations in our framework.
>>> make km_kirkwood
>> [...]
>> post/libpost.o: In function `post_time_ms':
>> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_ticks'
>> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_tbclk'
>>
>> So it seems that the kirkwood code has no implementation for these functions.
>> Any idea how to fix this?
>
> We must implement it ... Prafulla, can you comment this?
>
Or in the first step just add && !(CONFIG_MACH_KIRKWOOD) or similar to the
#ifdef until it is supported in the generic kirkwood code.
regards
Holger
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
2011-11-21 14:09 ` Heiko Schocher
2011-11-21 14:27 ` Holger Brunck
@ 2011-11-22 8:26 ` Prafulla Wadaskar
1 sibling, 0 replies; 6+ messages in thread
From: Prafulla Wadaskar @ 2011-11-22 8:26 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: Monday, November 21, 2011 7:40 PM
> To: Holger Brunck
> Cc: u-boot at lists.denx.de; Longchamp, Valentin; Falauto,
> Gerlando
> Subject: Re: [PATCH] arm, post: add missing post_time_ms for
> arm
>
> Hello Holger,
>
>
> added Prafulla Wadaskar to cc ...
>
> Holger Brunck wrote:
> > Hi Heiko,
> >
> > On 09/15/2011 07:34 AM, Heiko Schocher wrote:
> >> Signed-off-by: Heiko Schocher <hs@denx.de>
> >> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >> ---
> >> post/post.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/post/post.c b/post/post.c
> >> index 6c59f91..0bfca75 100644
> >> --- a/post/post.c
> >> +++ b/post/post.c
> >> @@ -488,7 +488,7 @@ void post_reloc(void)
> >> */
> >> unsigned long post_time_ms(unsigned long base)
> >> {
> >> -#ifdef CONFIG_PPC
> >> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
> >> return (unsigned long)(get_ticks() / (get_tbclk() /
> CONFIG_SYS_HZ))
> >> - base;
> >> #else
> >
> > this commit breaks post test support for our keymile arm
> boards:
>
> :-(
>
> I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post
> support
> worked for you before this patch? You should have seen this
> warning message:
>
> #warning "Not implemented yet"
>
> or?
>
> >> make km_kirkwood
> > [...]
> > post/libpost.o: In function `post_time_ms':
> > /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
> reference to `get_ticks'
> > /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
> reference to `get_tbclk'
> >
> > So it seems that the kirkwood code has no implementation for
> these functions.
> > Any idea how to fix this?
>
> We must implement it ... Prafulla, can you comment this?
As per my knowledge Kirkwood has no implementation for this.
Yes, we should implement this.
Patches are welcomed.
Regards..
Prafulla . . .
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
2011-09-15 5:34 [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm Heiko Schocher
2011-11-21 12:57 ` Holger Brunck
@ 2011-11-22 21:00 ` Mike Frysinger
1 sibling, 0 replies; 6+ messages in thread
From: Mike Frysinger @ 2011-11-22 21:00 UTC (permalink / raw)
To: u-boot
On Thursday 15 September 2011 01:34:33 Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> post/post.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/post/post.c b/post/post.c
> index 6c59f91..0bfca75 100644
> --- a/post/post.c
> +++ b/post/post.c
> @@ -488,7 +488,7 @@ void post_reloc(void)
> */
> unsigned long post_time_ms(unsigned long base)
> {
> -#ifdef CONFIG_PPC
> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
> return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
> - base;
> #else
almost no one uses the result of post_time_ms(), so the warning ends up being
spurious for most people.
are you enabling this define because you need the result ? or you just trying
to kill the warning ? if the latter, i think we should make this so it warns
only when appropriate ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/b73fe3fa/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-22 21:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 5:34 [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm Heiko Schocher
2011-11-21 12:57 ` Holger Brunck
2011-11-21 14:09 ` Heiko Schocher
2011-11-21 14:27 ` Holger Brunck
2011-11-22 8:26 ` Prafulla Wadaskar
2011-11-22 21:00 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox