From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra2: mmc: Enable card-detect for all interfaces.
Date: Mon, 21 Nov 2011 10:09:23 -0700 [thread overview]
Message-ID: <4ECA85C3.5090801@nvidia.com> (raw)
In-Reply-To: <1321864535-22023-1-git-send-email-thierry.reding@avionic-design.de>
On 11/21/2011 01:35 AM, Thierry Reding wrote:
> This commit drops the interface check for card-detection and leaves it
> up to the board whether or not a card-detect GPIO is connected. Also,
> the version field of struct mmc is only valid after the slot has been
> probed successfully, so depending on that information sort of defeats
> the purpose of card-detection.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Acked-by: Stephen Warren <swarren@nvidia.com>
BTW, in your earlier patch where you added a call to board_mmc_getcd()
to mmc_init(), do you also need to modify drivers/mmc/fsl_esdhc.c's
esdhc_init(), since the cd function has already been called?
BTW, you need to CC the MMC maintainers on these patches, or they
probably won't see them and they won't get applied. See
http://www.denx.de/wiki/U-Boot/Custodians.
--
nvpublic
next prev parent reply other threads:[~2011-11-21 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 8:35 [U-Boot] [PATCH] tegra2: mmc: Enable card-detect for all interfaces Thierry Reding
2011-11-21 17:09 ` Stephen Warren [this message]
2011-11-22 18:09 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECA85C3.5090801@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox