From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 21 Nov 2011 10:09:23 -0700 Subject: [U-Boot] [PATCH] tegra2: mmc: Enable card-detect for all interfaces. In-Reply-To: <1321864535-22023-1-git-send-email-thierry.reding@avionic-design.de> References: <1321864535-22023-1-git-send-email-thierry.reding@avionic-design.de> Message-ID: <4ECA85C3.5090801@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/21/2011 01:35 AM, Thierry Reding wrote: > This commit drops the interface check for card-detection and leaves it > up to the board whether or not a card-detect GPIO is connected. Also, > the version field of struct mmc is only valid after the slot has been > probed successfully, so depending on that information sort of defeats > the purpose of card-detection. > > Signed-off-by: Thierry Reding Acked-by: Stephen Warren BTW, in your earlier patch where you added a call to board_mmc_getcd() to mmc_init(), do you also need to modify drivers/mmc/fsl_esdhc.c's esdhc_init(), since the cd function has already been called? BTW, you need to CC the MMC maintainers on these patches, or they probably won't see them and they won't get applied. See http://www.denx.de/wiki/U-Boot/Custodians. -- nvpublic