public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] arm: printf() is not available in some SPL configurations
Date: Tue, 22 Nov 2011 09:49:46 +0100	[thread overview]
Message-ID: <4ECB622A.3070408@gmail.com> (raw)
In-Reply-To: <1321950379-25403-1-git-send-email-christian.riesch@omicron.at>

Dear Christian,

sorry I haven't followed the discussion so far. I have a little pointer too.

Am 22.11.2011 09:26, schrieb Christian Riesch:
> This patch avoids build breakage for SPLs that do not support printf.
> 
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Acked-by: Tom Rini <trini@ti.com>
> ---
> Changes for v3:
> - Removed extra white space
> - Separated patch from patchset [1]
> 
> [1] http://lists.denx.de/pipermail/u-boot/2011-November/110635.html
> 
>  arch/arm/lib/eabi_compat.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
> index eb3e26d..e1b87be 100644
> --- a/arch/arm/lib/eabi_compat.c
> +++ b/arch/arm/lib/eabi_compat.c
> @@ -13,7 +13,9 @@
>  
>  int raise (int signum)
>  {
> +#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
>  	printf("raise: Signal # %d caught\n", signum);
> +#endif

Well, you can do it that way but I guess there are several places where
printf() will be needed by some drivers in SPL. Therefore I think it is
better to provide printf() for SPL than to ifdef out all the printf's.

So how about providing an empty

#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
#define printf(x)
#endif

somewhere in the SPL code?

best regards

Andreas Bie?mann

  reply	other threads:[~2011-11-22  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  8:26 [U-Boot] [PATCH v3] arm: printf() is not available in some SPL configurations Christian Riesch
2011-11-22  8:49 ` Andreas Bießmann [this message]
2011-11-22  9:08   ` Christian Riesch
2011-11-22 20:20   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECB622A.3070408@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox