From: Aneesh V <aneesh@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] omap: remove I2C from SPL
Date: Wed, 23 Nov 2011 13:04:31 +0530 [thread overview]
Message-ID: <4ECCA207.4050200@ti.com> (raw)
In-Reply-To: <CA+M6bX=BWvUBE9yvQ-gj-eWxyxGzGsVqscNcHdCHxsSeASq1CA@mail.gmail.com>
On Tuesday 22 November 2011 09:22 PM, Tom Rini wrote:
> On Tue, Nov 22, 2011 at 2:39 AM, Aneesh V<aneesh@ti.com> wrote:
>> Due to some recent changes I2C is no longer required in SPL.
>> Remove the i2c_init() call to save some space
>
> Which changes? We might need to bring this back for am335x stuff,
> once we have i2c support ready to post to mainline (on these boards we
> identify board/rev in the EEPROM)
>
Apparently this one:
14fa2dd00f4f996c9583c8fba63bfa03f5025ec3
Looks like this is what has helped:
/* TWL6030 */
+#ifndef CONFIG_SPL_BUILD
#define CONFIG_TWL6030_POWER 1
+#endif
On a closer look, it looks like this may not be the case for OMAP3.
CONFIG_TWL4030_POWER seems to be defined even for SPL. So, I think we
need to do something like this:
#if defined(CONFIG_TWL6030_POWER) || defined(CONFIG_TWL4030_POWER) ||
defined(CONFIG_EEPROM)
i2c_init();
#endif
If you agree, I will do this change in v2.
BTW, I think you can also remove CONFIG_TWL4030_POWER from SPL. As we
continue to boot from the same media where ROM code picked up SPL from,
the regulators should be in proper condition.
br,
Aneesh
next prev parent reply other threads:[~2011-11-23 7:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 9:38 [U-Boot] [PATCH 0/9] omap: miscellaneous fixes and improvements Aneesh V
2011-11-22 9:38 ` [U-Boot] [PATCH 1/9] omap: Improve PLL parameter calculation tool Aneesh V
2011-11-22 9:38 ` [U-Boot] [PATCH 2/9] omap4: ttyO2 instead of ttyS2 in default bootargs Aneesh V
2011-11-22 9:38 ` [U-Boot] [PATCH 3/9] omap: fix cache line size for omap3/omap4 boards Aneesh V
2011-11-22 15:58 ` Tom Rini
2011-11-23 5:00 ` Aneesh V
2011-11-29 21:15 ` Tom Rini
2011-11-22 9:39 ` [U-Boot] [PATCH 4/9] omap4460: fix TPS initialization Aneesh V
2011-11-22 9:39 ` [U-Boot] [PATCH 5/9] omap: remove I2C from SPL Aneesh V
2011-11-22 15:52 ` Tom Rini
2011-11-23 7:34 ` Aneesh V [this message]
2011-11-23 15:05 ` Tom Rini
2011-11-22 9:39 ` [U-Boot] [PATCH 6/9] omap4: emif: fix error in driver Aneesh V
2011-11-22 9:39 ` [U-Boot] [PATCH 7/9] omap4460: add ES1.1 identification Aneesh V
2011-11-22 9:39 ` [U-Boot] [PATCH 8/9] omap4+: streamline CONFIG_SYS_TEXT_BASE and other SDRAM addresses Aneesh V
2011-11-22 9:39 ` [U-Boot] [PATCH 9/9] omap4: fix IO setting Aneesh V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCA207.4050200@ti.com \
--to=aneesh@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox