From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Wed, 23 Nov 2011 13:04:31 +0530
Subject: [U-Boot] [PATCH 5/9] omap: remove I2C from SPL
In-Reply-To: <CA+M6bX=BWvUBE9yvQ-gj-eWxyxGzGsVqscNcHdCHxsSeASq1CA@mail.gmail.com>
References: <1321954745-18112-1-git-send-email-aneesh@ti.com>	<1321954745-18112-6-git-send-email-aneesh@ti.com>
	<CA+M6bX=BWvUBE9yvQ-gj-eWxyxGzGsVqscNcHdCHxsSeASq1CA@mail.gmail.com>
Message-ID: <4ECCA207.4050200@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 22 November 2011 09:22 PM, Tom Rini wrote:
> On Tue, Nov 22, 2011 at 2:39 AM, Aneesh V<aneesh@ti.com>  wrote:
>> Due to some recent changes I2C is no longer required in SPL.
>> Remove the i2c_init() call to save some space
>
> Which changes?  We might need to bring this back for am335x stuff,
> once we have i2c support ready to post to mainline (on these boards we
> identify board/rev in the EEPROM)
>

Apparently this one:

14fa2dd00f4f996c9583c8fba63bfa03f5025ec3

Looks like this is what has helped:

  /* TWL6030 */
+#ifndef CONFIG_SPL_BUILD
  #define CONFIG_TWL6030_POWER           1
+#endif

On a closer look, it looks like this may not be the case for OMAP3.
CONFIG_TWL4030_POWER seems to be defined even for SPL. So, I think we
need to do something like this:

#if defined(CONFIG_TWL6030_POWER) || defined(CONFIG_TWL4030_POWER) || 
defined(CONFIG_EEPROM)

i2c_init();

#endif

If you agree, I will do this change in v2.

BTW, I think you can also remove CONFIG_TWL4030_POWER from SPL. As we
continue to boot from the same media where ROM code picked up SPL from,
the regulators should be in proper condition.

br,
Aneesh