* [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash()
@ 2011-11-05 21:12 Igor Grinberg
2011-11-23 9:23 ` Igor Grinberg
2011-11-27 9:06 ` [U-Boot] [PATCH v2] " Igor Grinberg
0 siblings, 2 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-11-05 21:12 UTC (permalink / raw)
To: u-boot
Fix parameters order in write_dataflash() function extern declaration in
the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
include/dataflash.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/dataflash.h b/include/dataflash.h
index 96ac097..094babb 100644
--- a/include/dataflash.h
+++ b/include/dataflash.h
@@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
extern int addr_dataflash (unsigned long addr);
extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
-extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
+extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
+ unsigned long size);
extern void dataflash_print_info (void);
extern void dataflash_perror (int err);
extern void AT91F_DataflashSetEnv (void);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash()
2011-11-05 21:12 [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash() Igor Grinberg
@ 2011-11-23 9:23 ` Igor Grinberg
2011-11-27 9:06 ` [U-Boot] [PATCH v2] " Igor Grinberg
1 sibling, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-11-23 9:23 UTC (permalink / raw)
To: u-boot
Hi all,
This is a trivial patch and it has been 18 days since posting it.
Can someone take care of it, please?
On 11/05/11 23:12, Igor Grinberg wrote:
> Fix parameters order in write_dataflash() function extern declaration in
> the header file.
> Parameters order, as in function definition, should be:
> addr_dest, addr_src, size.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> include/dataflash.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/dataflash.h b/include/dataflash.h
> index 96ac097..094babb 100644
> --- a/include/dataflash.h
> +++ b/include/dataflash.h
> @@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
> extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
> extern int addr_dataflash (unsigned long addr);
> extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
> -extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
> +extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
> + unsigned long size);
> extern void dataflash_print_info (void);
> extern void dataflash_perror (int err);
> extern void AT91F_DataflashSetEnv (void);
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] dataflash: fix parameters order in write_dataflash()
2011-11-05 21:12 [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash() Igor Grinberg
2011-11-23 9:23 ` Igor Grinberg
@ 2011-11-27 9:06 ` Igor Grinberg
2011-11-27 19:01 ` Anatolij Gustschin
1 sibling, 1 reply; 4+ messages in thread
From: Igor Grinberg @ 2011-11-27 9:06 UTC (permalink / raw)
To: u-boot
Fix parameters order in write_dataflash() function extern declaration in
the header file.
Parameters order, as in function definition, should be:
addr_dest, addr_src, size.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
v2: rebase on TOT
include/dataflash.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/dataflash.h b/include/dataflash.h
index 056e18b..94f86b3 100644
--- a/include/dataflash.h
+++ b/include/dataflash.h
@@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
extern int addr_dataflash (unsigned long addr);
extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
-extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
+extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
+ unsigned long size);
extern int AT91F_DataflashInit(void);
extern void dataflash_print_info (void);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] dataflash: fix parameters order in write_dataflash()
2011-11-27 9:06 ` [U-Boot] [PATCH v2] " Igor Grinberg
@ 2011-11-27 19:01 ` Anatolij Gustschin
0 siblings, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2011-11-27 19:01 UTC (permalink / raw)
To: u-boot
On Sun, 27 Nov 2011 11:06:46 +0200
Igor Grinberg <grinberg@compulab.co.il> wrote:
> Fix parameters order in write_dataflash() function extern declaration in
> the header file.
> Parameters order, as in function definition, should be:
> addr_dest, addr_src, size.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> v2: rebase on TOT
>
> include/dataflash.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Applied to u-boot-staging/agust at denx.de. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-27 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-05 21:12 [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash() Igor Grinberg
2011-11-23 9:23 ` Igor Grinberg
2011-11-27 9:06 ` [U-Boot] [PATCH v2] " Igor Grinberg
2011-11-27 19:01 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox