[U-Boot] [GIT PULL] Pull request: u-boot-staging

Andy Fleming
2011-11-23T17:08:15Z

On Wed, Nov 23, 2011 at 10:57 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 23/11/2011 17:26, Igor Grinberg wrote:
>> Hi Wolfgang, Stefano,
>>
>
> Hi Igor,
>
> to add maybe some confusion here I have now checked into U-Boot log and
> I see that at least one custodian (Paulraj, I have added now in CC)
> follows the Linux way.
>
>>> The question is how you define "pushing".
>>> "Documentation/SubmittingPatches" says:
>>>
>>> | ? ? ? ? By making a contribution to this project, I certify that:
>>> |
>>> | ? ? ? ? (a) The contribution was created in whole or in part by me and I
>>> | ? ? ? ? ? ? have the right to submit it under the open source license
>>> | ? ? ? ? ? ? indicated in the file; or
>>> |
>>> | ? ? ? ? (b) The contribution is based upon previous work that, to the best
>>> | ? ? ? ? ? ? of my knowledge, is covered under an appropriate open source
>>> | ? ? ? ? ? ? license and I have the right under that license to submit that
>>> | ? ? ? ? ? ? work with modifications, whether created in whole or in part
>>> | ? ? ? ? ? ? by me, under the same open source license (unless I am
>>> | ? ? ? ? ? ? permitted to submit under a different license), as indicated
>>> | ? ? ? ? ? ? in the file; or
>>> |
>>> | ? ? ? ? (c) The contribution was provided directly to me by some other
>>> | ? ? ? ? ? ? person who certified (a), (b) or (c) and I have not modified
>>> | ? ? ? ? ? ? it.
>>> |
>>> | ? ? ? ? (d) I understand and agree that this project and the contribution
>>> | ? ? ? ? ? ? are public and that a record of the contribution (including all
>>> | ? ? ? ? ? ? personal information I submit with it, including my sign-off) is
>>> | ? ? ? ? ? ? maintained indefinitely and may be redistributed consistent with
>>> | ? ? ? ? ? ? this project or the open source license(s) involved.
>>> |
>>> | then you just add a line saying
>>> |
>>> | ? ? ? ? Signed-off-by: Random J Developer <random@developer.example.org>
>>>
>>> (a) and (b) don't apply here, and (d) is not relevant in this context.
>>> So the question is if (c) applies, or not.
>>
>> Well, I think yes (c) applies here and if you look into the Linux
>> git log, you will see that all patches applied by maintainers are
>> also signed by them.
>
> Reading (c), I can interprete as Igor does...

I've been not signing off on applied mmc patches, but now that I read
the document carefully, I agree with Igor's interpretation. If you
look under section 13:

13) When to use Acked-by: and Cc:

The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.

I think that makes the intent of (c) clear.

Of course, the meaning is established on a per-project basis. And
Wolfgang is right that the same interpretation could be used to claim
that Albert should add his signed-off-by to every patch merged from
the various ARM-sub-repositories. So I think we just need to establish
what the policy is for U-Boot, and everyone can follow it from now-on.