From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup
Date: Thu, 24 Nov 2011 09:33:20 +0200 [thread overview]
Message-ID: <4ECDF340.6060208@compulab.co.il> (raw)
In-Reply-To: <1322077682-12838-1-git-send-email-galak@kernel.crashing.org>
Hi Kumar,
Sorry for that one.
On 11/23/11 21:48, Kumar Gala wrote:
> cmd_nvedit.c: In function 'do_env_grep':
> cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> common/cmd_nvedit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
> index 7409a36..5995354 100644
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag,
>
> while (arg <= argc) {
> idx = 0;
> - while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) {
> + while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) {
> if (!(matched[idx / 8] & (1 << (idx & 7)))) {
> puts(match->key);
> puts("=");
--
Regards,
Igor.
next prev parent reply other threads:[~2011-11-24 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 19:48 [U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup Kumar Gala
2011-11-23 22:18 ` Mike Frysinger
2011-11-24 7:33 ` Igor Grinberg [this message]
2011-11-27 14:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECDF340.6060208@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox