[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

[Kumar Gala]

cmd_nvedit.c: In function 'do_env_grep':
cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 common/cmd_nvedit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 7409a36..5995354 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag,
 
 	while (arg <= argc) {
 		idx = 0;
-		while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) {
+		while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) {
 			if (!(matched[idx / 8] & (1 << (idx & 7)))) {
 				puts(match->key);
 				puts("=");
-- 
1.7.3.4

[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

[Mike Frysinger]

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111123/2a54a81c/attachment.pgp>

[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

[Igor Grinberg]

Hi Kumar,

Sorry for that one.

On 11/23/11 21:48, Kumar Gala wrote:
> cmd_nvedit.c: In function 'do_env_grep':
> cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
>  common/cmd_nvedit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
> index 7409a36..5995354 100644
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag,
>  
>  	while (arg <= argc) {
>  		idx = 0;
> -		while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) {
> +		while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) {
>  			if (!(matched[idx / 8] & (1 << (idx & 7)))) {
>  				puts(match->key);
>  				puts("=");

-- 
Regards,
Igor.

[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

[Wolfgang Denk]

Dear Kumar Gala,

In message <1322077682-12838-1-git-send-email-galak@kernel.crashing.org> you wrote:
> cmd_nvedit.c: In function 'do_env_grep':
> cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  common/cmd_nvedit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If some day we are defeated, well, war has  its  fortunes,  good  and
bad.
	-- Commander Kor, "Errand of Mercy", stardate 3201.7