From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 24 Nov 2011 20:13:53 +0100 Subject: [U-Boot] [PATCH] microblaze: usable uart16550 for big endian systems In-Reply-To: <1322159381.3870.195.camel@keto> References: <1321704237-10626-1-git-send-email-linz@li-pro.net> <4EC9FBDF.8070800@monstr.eu> <1321899537.3870.132.camel@keto> <4ECD05EF.3020005@monstr.eu> <1322159381.3870.195.camel@keto> Message-ID: <4ECE9771.7080403@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stephan Linz wrote: > Am Mittwoch, den 23.11.2011, 15:40 +0100 schrieb Michal Simek: >> Hi Stephan, >> >>>> Stephan Linz wrote: >>>>> As a result of the commit 6833260 the uart16550 driver >>>>> is broken for Microblaze big endian systems, because of >>>>> the missing 3 byte offset. Other than as described, the >>>>> U-Boot BSP does not treat properly the 3 byte offset. >>>>> >>>>> However, with the new 32 bit access to ns16550 registers >>>>> we can enable correct register access for Microblaze big >>>>> and little endian systems in the same manner. >>>> The reason why I have applied that patch is that baseaddress generation >>>> was moved to u-boot BSP out of u-boot configs. >>>> >>>> --snip-- >>>> Anyway you solution looks interesting and I will test it. >>> However since commit 79df120 we can use direct 32 bit access to 8 bit >>> NS16550 registers without gap generation in ns16550.h ... we need sane >>> in_*/out_* implementation. >>> >> I have look at it and tested on BE/LE. For 32bit accesses we need to implement >> in/out_le32 functions which we don't have right now > > Hi Michal, > > Oh yes, of course. There are no *_le32 operations, not yet. > >> that's why please remove this macro >> from your patch. >> >> Our BSP generates/ed +3 offset that's why I prefer to mask it in the same patch >> to be sure that baseaddr is correct and compatible with old versions. >> >> Here is patch I have used. Please add that changes to v2 patch. > > I'll do it this way. Give me a little time to change and test it. > Currently I am sill working on refactoring of the LL TEMAC driver. I > hope, the refactored driver than can merge in mainline ... I have done it some time ago and look at "[PATCH v3] net: ll_temac: Add LL TEMAC driver to u-boot thread". I have attached the latest version I have and I am not going to change it to follow "new" u-boot network driver style because I would like to keep ppc dcr support. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian -------------- next part -------------- A non-text attachment was scrubbed... Name: xilinx_ll_temac.c Type: text/x-csrc Size: 17099 bytes Desc: not available URL: