From mboxrd@z Thu Jan  1 00:00:00 1970
From: stefano babic <sbabic@denx.de>
Date: Thu, 24 Nov 2011 23:42:00 +0100
Subject: [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration
 for Technexion TAM3517
In-Reply-To: <20111124204307.D6A2C1FFB39F@gemini.denx.de>
References: <1322040416-11751-1-git-send-email-sbabic@denx.de>
	<1322149442-16555-1-git-send-email-sbabic@denx.de>
	<20111124204307.D6A2C1FFB39F@gemini.denx.de>
Message-ID: <4ECEC838.60807@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 24/11/2011 21:43, schrieb Wolfgang Denk:
>> +	"hostname=" xstr(CONFIG_HOSTNAME) "\0"				\
>> +	"bootfile=" xstr(CONFIG_HOSTNAME) "/uImage\0"			\
> 
> Here you rely on xstr() being defined in some higher level header
> file.

This was not thought, I miss to move it, thanks for pointing out

>  That's not a good idea.

..it's a very bad idea....

>  Please mode the definitions into this
> common header, and drop it in the other file(s).

I do it

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================