From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools/envcrc: fix compile breakage
Date: Tue, 29 Nov 2011 08:38:02 +0200 [thread overview]
Message-ID: <4ED47DCA.4010107@compulab.co.il> (raw)
In-Reply-To: <20111128151549.D737E2002563@gemini.denx.de>
On 11/28/11 17:15, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> In message <4ED34E9B.7040200@compulab.co.il> you wrote:
>>
>>> Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED
>>> is set, but CONFIG_BUILD_ENVCRC is _not_ set?
>>
>> Well, you should look into that file...
>
> It's faster for me to ask you to do that :-)
I have already done that (before sending the patch) as soon as I saw
the email from Mike, reporting the problem.
>
>>> Did this change pass a MAKEALL for example for ppc?
>>
>> I don't have the tool chain for ppc.
>> I think the original fix has been tested by Stefano.
>> Is there a requirement to have all the supported
>> architectures tool chains, for submitting patches?
>
> Not for all, but http://www.denx.de/wiki/U-Boot/Patches says "Please
> also run MAKEALL for _at_least_one_other_architecture_ than the one you
> made your modifications in."
10x for looking into that for me ;-)
--
Regards,
Igor.
next prev parent reply other threads:[~2011-11-29 6:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:13 [U-Boot] [PATCH 00/17] Cleanup environment related files Igor Grinberg
2011-11-07 11:13 ` [U-Boot] [PATCH 01/17] env: clean environment.h checkpatch and code style Igor Grinberg
2011-11-07 11:13 ` [U-Boot] [PATCH 02/17] common: move extern char console_buffer[] to common.h Igor Grinberg
2011-11-07 11:13 ` [U-Boot] [PATCH 03/17] env: move extern default_environment[] to environment.h Igor Grinberg
2011-11-07 11:17 ` Stefan Roese
2011-11-17 14:12 ` Stefano Babic
2011-11-17 15:14 ` Igor Grinberg
2011-11-17 15:30 ` Stefano Babic
2011-11-17 16:07 ` [U-Boot] [PATCH v2 04/17] env: move extern environment[] " Igor Grinberg
2011-11-25 21:12 ` Mike Frysinger
2011-11-27 8:31 ` Igor Grinberg
2011-11-28 7:57 ` [U-Boot] [PATCH] tools/envcrc: fix compile breakage Igor Grinberg
2011-11-28 8:07 ` Wolfgang Denk
2011-11-28 9:04 ` Igor Grinberg
2011-11-28 15:15 ` Wolfgang Denk
2011-11-29 6:38 ` Igor Grinberg [this message]
2011-11-28 18:52 ` Mike Frysinger
2011-11-29 6:35 ` Igor Grinberg
2011-11-28 8:18 ` Wolfgang Denk
2011-11-28 8:53 ` Igor Grinberg
2011-11-29 4:25 ` Mike Frysinger
2011-11-29 6:41 ` Igor Grinberg
2011-12-05 10:48 ` Igor Grinberg
2011-12-06 21:11 ` Wolfgang Denk
2011-11-07 11:13 ` [U-Boot] [PATCH 04/17] env: move extern environment[] to environment.h Igor Grinberg
2011-11-07 11:13 ` [U-Boot] [PATCH 05/17] env: clean cmd_nvedit.c checkpatch and code style Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 06/17] env: clean env_nowhere.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 07/17] env: clean env_mgdisk.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 08/17] env: clean env_dataflash.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 09/17] env: clean env_onenand.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 10/17] env: clean env_nvram.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 11/17] env: clean env_mmc.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 12/17] env: clean env_embedded.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 13/17] env: clean env_eeprom.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 14/17] env: clean env_sf.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 15/17] env: clean env_flash.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 16/17] env: clean env_nand.c " Igor Grinberg
2011-11-07 11:14 ` [U-Boot] [PATCH 17/17] env: clean env_common.c " Igor Grinberg
2011-11-13 8:29 ` [U-Boot] [PATCH 00/17] Cleanup environment related files Igor Grinberg
2011-11-22 8:52 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED47DCA.4010107@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox