From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Tue, 29 Nov 2011 08:38:02 +0200 Subject: [U-Boot] [PATCH] tools/envcrc: fix compile breakage In-Reply-To: <20111128151549.D737E2002563@gemini.denx.de> References: <201111251612.34081.vapier@gentoo.org> <1322467058-30532-1-git-send-email-grinberg@compulab.co.il> <20111128080716.552A716FDDD6@gemini.denx.de> <4ED34E9B.7040200@compulab.co.il> <20111128151549.D737E2002563@gemini.denx.de> Message-ID: <4ED47DCA.4010107@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/28/11 17:15, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <4ED34E9B.7040200@compulab.co.il> you wrote: >> >>> Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED >>> is set, but CONFIG_BUILD_ENVCRC is _not_ set? >> >> Well, you should look into that file... > > It's faster for me to ask you to do that :-) I have already done that (before sending the patch) as soon as I saw the email from Mike, reporting the problem. > >>> Did this change pass a MAKEALL for example for ppc? >> >> I don't have the tool chain for ppc. >> I think the original fix has been tested by Stefano. >> Is there a requirement to have all the supported >> architectures tool chains, for submitting patches? > > Not for all, but http://www.denx.de/wiki/U-Boot/Patches says "Please > also run MAKEALL for _at_least_one_other_architecture_ than the one you > made your modifications in." 10x for looking into that for me ;-) -- Regards, Igor.