From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Tue, 29 Nov 2011 07:56:13 +0100
Subject: [U-Boot] [PATCH v3 3/3] arm,
 davinci: add support for am1808 based enbw_cmc board
In-Reply-To: <20111128154201.9FA7E1ADFED7@gemini.denx.de>
References: <1322477089-32368-1-git-send-email-hs@denx.de>
	<1322477089-32368-4-git-send-email-hs@denx.de>
	<4ED373C6.5020906@compulab.co.il> <4ED3A6A8.5010301@denx.de>
	<20111128154201.9FA7E1ADFED7@gemini.denx.de>
Message-ID: <4ED4820D.9080105@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang,

Wolfgang Denk schrieb:
> Dear Heiko Schocher,
> 
> In message <4ED3A6A8.5010301@denx.de> you wrote:
>>>> +		ret = gpio_request(gpio, enbw_gpio_config[i].name);
>>>> +		if (ret)
>>>> +			printf("%s: Could not get %s gpio\n", __func__,
>>>> +				enbw_gpio_config[i].name);
>>>> +		else
>>> instead of having that else and adding another level of indentation below
>>> you can just add continue;
>> Done.
> 
> Is this really a good idea??

Fixed that. If there is an error, we return instead.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany