From mboxrd@z Thu Jan  1 00:00:00 1970
From: Graeme Russ <graeme.russ@gmail.com>
Date: Wed, 30 Nov 2011 22:04:36 +1100
Subject: [U-Boot] [PATCH v2] x86: Fix some bugs in the i8402 driver when
 no controller is present
In-Reply-To: <1321337892-12367-1-git-send-email-gabeblack@chromium.org>
References: <4EBE49F0.9040903@gmail.com>
	<1321337892-12367-1-git-send-email-gabeblack@chromium.org>
Message-ID: <4ED60DC4.7080409@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Gabe,

On 15/11/11 17:18, Gabe Black wrote:
> If no controller is present, the i8402 driver should return immediately and
> not attempt to operate on the missing hardware.
> 
> In kbd_input_empty, the status register is checked every millisecond to see
> whether the input buffer is empty, up to a timeout which is tracked by
> decrimenting a counter each time the check is performed. The decrement is
> performed with a postfix -- operator, and the value of the counter is
> checked in place. That means that when the counter reaches zero and the
> loop terminates, it will actually be decrimented one more time and become
> -1. That value is returned as the return value of the function. That would
> give the right answer if it wasn't for that extra decrement because a
> timeout would indicate that the buffer never became empty.
> 
> This change fixes both of those bugs.
> 
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
> Changes in v2:
> - Change summary tag style.
> - Rebase onto checkpatch cleaned file.
> 
>  drivers/input/i8042.c |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)

Applied to u-boot-x86/master

Thanks,

Graeme