From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Thu, 01 Dec 2011 16:21:09 +0100 Subject: [U-Boot] [PATCH] fw_env.h: added a few missing defines In-Reply-To: <1322746204-4393-1-git-send-email-fransmeulenbroeks@gmail.com> References: <1322746204-4393-1-git-send-email-fransmeulenbroeks@gmail.com> Message-ID: <4ED79B65.7090200@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Frans Meulenbroeks, Am 01.12.2011 14:30, schrieb Frans Meulenbroeks: > The README file lists 4 defined that were not actually present in the .h > file but that were needed to get things working with settings compiled in. > They are > Added these to the .h file > (the values above are the ones from the README file) > > Signed-off-by: Frans Meulenbroeks I tend to NAK this. > --- > tools/env/fw_env.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h > index 9258c79..2dcb373 100644 > --- a/tools/env/fw_env.h > +++ b/tools/env/fw_env.h > @@ -34,8 +34,12 @@ > #define DEVICE2_NAME "/dev/mtd2" > #define DEVICE1_OFFSET 0x0000 > #define ENV1_SIZE 0x4000 > +#define DEVICE1_ESIZE 0x4000 > +#define DEVICE1_ENVSECTORS 2 This change will overwrite the settings done by ENV1_SIZE ... and none of the settings match my boards needs ;) I would appreciate you test my patch http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/106972/focus=112948 or http://patchwork.ozlabs.org/patch/120372/ I guess you could fulfil your requirements with that patch too. best regards Andreas Bie?mann