From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mtd/nand: Fixup for support ONFI detect
Date: Fri, 2 Dec 2011 12:32:08 -0600 [thread overview]
Message-ID: <4ED919A8.4070702@freescale.com> (raw)
In-Reply-To: <1322817437-4955-2-git-send-email-Shengzhou.Liu@freescale.com>
On 12/02/2011 03:17 AM, Shengzhou Liu wrote:
> There was a bug logically in the order of nand_flash_detect_onfi
> and checking nand_flash_ids. We should get NAND devices related
> informations first by ONFI method instead of querying nand_flash_ids table,
> if ONFI fails, then query nand_flash_ids table.
ONFI issues should be taken care of with the patchset to sync NAND with
Linux that was recently posted. It has some minor issues, which
hopefully will be addressed by the next merge window.
I disagree that we should check ONFI first -- this is not what Linux
does. U-Boot's problem is that it aborts before ever checking ONFI, if
the device is not found in the table (and the Linux code suggests that
ONFI devices won't be found in the table).
-Scott
next prev parent reply other threads:[~2011-12-02 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 9:17 [U-Boot] [PATCH 1/4] mtd/nand : Add function board_nand_init_tail() for some special NAND controllers Shengzhou Liu
2011-12-02 9:17 ` [U-Boot] [PATCH 2/4] mtd/nand: Fixup for support ONFI detect Shengzhou Liu
2011-12-02 9:17 ` [U-Boot] [PATCH 3/4] mtd/nand: remove CONFIG_SYS_NAND_ONFI_DETECTION to enable ONFI detection Shengzhou Liu
2011-12-02 9:17 ` [U-Boot] [PATCH 4/4] mtd/nand: Add ONFI support for FSL NAND controller Shengzhou Liu
2011-12-02 18:45 ` Scott Wood
[not found] ` <3F453DDFF675A64A89321A1F352810216B03B9@039-SN1MPN1-005.039d.mgd.msft.net>
2011-12-05 19:17 ` Scott Wood
2011-12-02 18:32 ` Scott Wood [this message]
[not found] ` <3F453DDFF675A64A89321A1F352810216B0393@039-SN1MPN1-005.039d.mgd.msft.net>
2011-12-05 19:20 ` [U-Boot] [PATCH 2/4] mtd/nand: Fixup for support ONFI detect Scott Wood
2011-12-04 9:04 ` [U-Boot] [PATCH 1/4] mtd/nand : Add function board_nand_init_tail() for some special NAND controllers Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED919A8.4070702@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox