From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 2 Dec 2011 13:07:22 -0700 Subject: [U-Boot] [PATCH v4 4/6] arm, da850evm: Add an SPL for SPI boot In-Reply-To: <1322842330-25213-5-git-send-email-christian.riesch@omicron.at> References: <1322842330-25213-1-git-send-email-christian.riesch@omicron.at> <1322842330-25213-5-git-send-email-christian.riesch@omicron.at> Message-ID: <4ED92FFA.3080701@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/02/2011 09:12 AM, Christian Riesch wrote: [snip] > include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++ [snip] > +#define CONFIG_SYS_DA850_DDR2_SDTIMR (0 | \ > + (14 << DV_DDR_SDTMR1_RFC_SHIFT) | \ > + (2 << DV_DDR_SDTMR1_RP_SHIFT) | \ > + (2 << DV_DDR_SDTMR1_RCD_SHIFT) | \ > + (1 << DV_DDR_SDTMR1_WR_SHIFT) | \ > + (5 << DV_DDR_SDTMR1_RAS_SHIFT) | \ > + (8 << DV_DDR_SDTMR1_RC_SHIFT) | \ > + (1 << DV_DDR_SDTMR1_RRD_SHIFT) | \ > + (0 << DV_DDR_SDTMR1_WTR_SHIFT)) '0 | ..' and '0 << ...' don't help readability over just value saying it (same with shifting 0). Also, unless the manual these come from uses decimal here, hex is preferred. Thanks! -- Tom