From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: fix endianess handling
Date: Sun, 04 Dec 2011 23:32:21 +0900 [thread overview]
Message-ID: <4EDB8475.1080305@pobox.com> (raw)
In-Reply-To: <CACUy__XYf2Zo3d0SQ7Ub-ea37C2X=gZ+bTMTX95vz+YdAeQhDw@mail.gmail.com>
On 12/4/11 9:02 PM, Daniel Schwierzeck wrote:
>> diff --git a/boards.cfg b/boards.cfg
>> index c83d861..2cd917e 100644
>> --- a/boards.cfg
>> +++ b/boards.cfg
>> @@ -324,13 +324,13 @@ dbau1000 mips mips32 dbau1x00 -
>> dbau1100 mips mips32 dbau1x00 - au1x00 dbau1x00:DBAU1100
>> dbau1500 mips mips32 dbau1x00 - au1x00 dbau1x00:DBAU1500
>> dbau1550 mips mips32 dbau1x00 - au1x00 dbau1x00:DBAU1550
>> -dbau1550_el mips mips32 dbau1x00 - au1x00 dbau1x00:DBAU1550
>> +dbau1550_el mips mips32 dbau1x00 - au1x00 dbau1x00:DBAU1550,SYS_LITTLE_ENDIAN
This looks Ok.
>> gth2 mips mips32 - - au1x00
>> incaip mips mips32 incaip - incaip
>> incaip_100MHz mips mips32 incaip - incaip incaip:CPU_CLOCK_RATE=100000000
>> incaip_133MHz mips mips32 incaip - incaip incaip:CPU_CLOCK_RATE=133000000
>> incaip_150MHz mips mips32 incaip - incaip incaip:CPU_CLOCK_RATE=150000000
>> -pb1000 mips mips32 pb1x00 - au1x00 pb1x00:PB1000
>> +pb1000 mips mips32 pb1x00 - au1x00 pb1x00:PB1000,SYS_LITTLE_ENDIAN
>> qemu_mips mips mips32 qemu-mips - - qemu-mips
>> tb0229 mips mips32
>> vct_premium mips mips32 vct micronas - vct:VCT_PREMIUM
But I don't see any reason CONFIG_SYS_LITTLE_ENDIAN is specified in
boards.cfg. Just putting it in configs/pb1000.h is enough, isn't it?
> Shinya, do you have an opinion about this?
No, if it works for you, I'm fine. Thanks for tackling this issue.
Does anyone disagree with this change? If not, I'll pick this up.
>> diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile
>> index e23865b..eab23b4 100644
>> --- a/examples/standalone/Makefile
>> +++ b/examples/standalone/Makefile
>> @@ -88,6 +88,10 @@ endif
>> CFLAGS_NTR := $(call cc-option,-fno-toplevel-reorder)
>> CFLAGS += $(CFLAGS_NTR)
>>
>> +# Pass through endianess settings in LDFLAGS to LD
s/endianess/endianness/
next prev parent reply other threads:[~2011-12-04 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 13:42 [U-Boot] [PATCH] MIPS: fix endianess handling Daniel Schwierzeck
[not found] ` <CACUy__XYf2Zo3d0SQ7Ub-ea37C2X=gZ+bTMTX95vz+YdAeQhDw@mail.gmail.com>
2011-12-04 14:32 ` Shinya Kuribayashi [this message]
2011-12-04 15:08 ` Wolfgang Denk
2011-12-05 0:10 ` Daniel Schwierzeck
2012-03-31 20:54 ` Marek Vasut
[not found] ` <4EDB5F86.40605@googlemail.com>
2011-12-04 15:06 ` Wolfgang Denk
2011-12-05 0:04 ` Daniel Schwierzeck
2011-12-05 10:05 ` Wolfgang Denk
2011-12-07 12:59 ` [U-Boot] [PATCH v2] " Daniel Schwierzeck
2011-12-11 16:53 ` [U-Boot] [PATCH v3] " Daniel Schwierzeck
2011-12-16 18:12 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDB8475.1080305@pobox.com \
--to=skuribay@pobox.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox