From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Mon, 05 Dec 2011 01:10:35 +0100 Subject: [U-Boot] [PATCH] MIPS: fix endianess handling In-Reply-To: <20111204150859.7F4E9824CD@gemini.denx.de> References: <1322487768-19439-1-git-send-email-daniel.schwierzeck@googlemail.com> <4EDB8475.1080305@pobox.com> <20111204150859.7F4E9824CD@gemini.denx.de> Message-ID: <4EDC0BFB.4080802@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/04/2011 04:08 PM, Wolfgang Denk wrote: > Dear Shinya Kuribayashi, > > In message<4EDB8475.1080305@pobox.com> you wrote: >> >>>> -pb1000 mips mips32 pb1x00 - au1x00 pb1x00:PB1000 >>>> +pb1000 mips mips32 pb1x00 - au1x00 pb1x00:PB1000,SYS_LITTLE_ENDIAN > ... >> But I don't see any reason CONFIG_SYS_LITTLE_ENDIAN is specified in >> boards.cfg. Just putting it in configs/pb1000.h is enough, isn't it? > > Agreed. In almost all cases this should be done in the board config > file only. Only if there are cases where a board suppors both LE and > BE configurations (is there any such board??) then we should need a > SYS_*_ENDIAN setting in boards.cfg (but even then, only one - not > two). I did this because of dbau1550 and dbau1550_el. For the pb1000 I'll move it to the board config. > > Best regards, > > Wolfgang Denk > -- Best regards, Daniel